c665201b85
This patch provides the support of synchronous cache space recovery to allow read threads to recover from ENOSPC errors when cache space can be recovered from cache items that are not in use or safe to be reset/emptied . The patch complements the existing cache cleaning process in two ways. Firstly, the existing cache cleaning process is time-driven that runs periodically. The cache space can run out while the cache cleaner thread is still waiting for its next scheduled run. The io threads encountering ENOSPC return an internal error to the applications in this case even when cache space can be recovered to avoid this error. This patch addresses this problem by having the read threads kick the cache cleaner thread in this condition to recover cache space preventing unnecessary ENOSPC errors from being seen by the applications. Secondly, this patch enhances the cache cleaner to support cache item reset. Currently the cache purge process removes cache items that are not in use. This may not be sufficient when the total size of the working set exceeds the cache directory's capacity. Like in the current code, this patch starts the purge process by removing cache files that are not in use. Cache items whose access times are older than vfs-cache-max-age are removed first. After that, other not-in-use items are removed in LRU order until vfs-cache-max-size is reached. If the vfs-cache-max-size (the quota) is still not reached at this time, this patch adds a cache reset step to reset/empty cache files that are still in use but not dirtied. This enables application processes to continue without seeing an error even when the working set depletes the cache space as long as there is not a large write working set hoarding the entire cache space. By design this patch does not add ENOSPC error recovery for write IOs. Rclone does not empty a write cache item until the file data is written back to the backend upon close. Allowing more cache space to be consumed by dirty cache items when the cache space is already running low would increase the risk of exhausting the cache space in a way that the vfs mount becomes unreadable.
23 lines
387 B
Go
23 lines
387 B
Go
// +build !plan9
|
|
|
|
package fserrors
|
|
|
|
import (
|
|
"syscall"
|
|
|
|
"github.com/rclone/rclone/lib/errors"
|
|
)
|
|
|
|
// IsErrNoSpace checks a possibly wrapped error to
|
|
// see if it contains a ENOSPC error
|
|
func IsErrNoSpace(cause error) (isNoSpc bool) {
|
|
errors.Walk(cause, func(c error) bool {
|
|
if c == syscall.ENOSPC {
|
|
isNoSpc = true
|
|
return true
|
|
}
|
|
isNoSpc = false
|
|
return false
|
|
})
|
|
return
|
|
}
|