TrueCloudLab/restic
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Remove broken --allow-root from restic mount

Browse source
This commit is contained in:
greatroar 2020-03-17 23:32:09 +01:00
parent c542a509f0
commit 18fee4806f
3 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cmd/restic/cmd_mount.go
View file

@ -59,7 +59,6 @@ Exit status is 0 if the command was successful, and non-zero if there was any er
// MountOptions collects all options for the mount command. // MountOptions collects all options for the mount command.
type MountOptions struct { type MountOptions struct {
OwnerRoot bool OwnerRoot bool
AllowRoot bool
AllowOther bool AllowOther bool
NoDefaultPermissions bool NoDefaultPermissions bool
Hosts []string Hosts []string
@ -75,7 +74,6 @@ func init() {
mountFlags := cmdMount.Flags() mountFlags := cmdMount.Flags()
mountFlags.BoolVar(&mountOptions.OwnerRoot, "owner-root", false, "use 'root' as the owner of files and dirs") mountFlags.BoolVar(&mountOptions.OwnerRoot, "owner-root", false, "use 'root' as the owner of files and dirs")
mountFlags.BoolVar(&mountOptions.AllowRoot, "allow-root", false, "allow root user to access the data in the mounted directory")
mountFlags.BoolVar(&mountOptions.AllowOther, "allow-other", false, "allow other users to access the data in the mounted directory") mountFlags.BoolVar(&mountOptions.AllowOther, "allow-other", false, "allow other users to access the data in the mounted directory")
mountFlags.BoolVar(&mountOptions.NoDefaultPermissions, "no-default-permissions", false, "for 'allow-other', ignore Unix permissions and allow users to read all snapshot files") mountFlags.BoolVar(&mountOptions.NoDefaultPermissions, "no-default-permissions", false, "for 'allow-other', ignore Unix permissions and allow users to read all snapshot files")
@ -119,10 +117,6 @@ func mount(opts MountOptions, gopts GlobalOptions, mountpoint string) error {
systemFuse.FSName("restic"), systemFuse.FSName("restic"),
} }
if opts.AllowRoot {
mountOptions = append(mountOptions, systemFuse.AllowRoot())
}
if opts.AllowOther { if opts.AllowOther {
mountOptions = append(mountOptions, systemFuse.AllowOther()) mountOptions = append(mountOptions, systemFuse.AllowOther())

2
doc/bash-completion.sh
View file

@ -1026,8 +1026,6 @@ _restic_mount()
flags+=("--allow-other") flags+=("--allow-other")
local_nonpersistent_flags+=("--allow-other") local_nonpersistent_flags+=("--allow-other")
flags+=("--allow-root")
local_nonpersistent_flags+=("--allow-root")
flags+=("--help") flags+=("--help")
flags+=("-h") flags+=("-h")
local_nonpersistent_flags+=("--help") local_nonpersistent_flags+=("--help")

4
doc/man/restic-mount.1
View file

@ -56,10 +56,6 @@ For details please see the documentation for time.Format() at:
\fB\-\-allow\-other\fP[=false] \fB\-\-allow\-other\fP[=false]
allow other users to access the data in the mounted directory allow other users to access the data in the mounted directory
.PP
\fB\-\-allow\-root\fP[=false]
allow root user to access the data in the mounted directory
.PP .PP
\fB\-h\fP, \fB\-\-help\fP[=false] \fB\-h\fP, \fB\-\-help\fP[=false]
help for mount help for mount