TrueCloudLab/restic
16
0
Fork 2
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

restore: check file type in verify

Browse source
This commit is contained in:
Michael Eischer 2024-05-22 17:36:52 +02:00
parent 663151db57
commit 8aa3ab6ef8
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
internal/restorer/restorer.go
View file

@ -473,7 +473,7 @@ func (res *Restorer) VerifyFiles(ctx context.Context, dst string) (int, error) {
// Reusing buffers prevents the verifier goroutines allocating all of RAM and // Reusing buffers prevents the verifier goroutines allocating all of RAM and
// flushing the filesystem cache (at least on Linux). // flushing the filesystem cache (at least on Linux).
func (res *Restorer) verifyFile(target string, node *restic.Node, buf []byte) ([]byte, error) { func (res *Restorer) verifyFile(target string, node *restic.Node, buf []byte) ([]byte, error) {
f, err := os.Open(target) f, err := os.OpenFile(target, fs.O_RDONLY|fs.O_NOFOLLOW, 0)
if err != nil { if err != nil {
return buf, err return buf, err
} }
@ -485,6 +485,8 @@ func (res *Restorer) verifyFile(target string, node *restic.Node, buf []byte) ([
switch { switch {
case err != nil: case err != nil:
return buf, err return buf, err
case !fi.Mode().IsRegular():
return buf, errors.Errorf("Expected %s to be a regular file", target)
case int64(node.Size) != fi.Size(): case int64(node.Size) != fi.Size():
return buf, errors.Errorf("Invalid file size for %s: expected %d, got %d", return buf, errors.Errorf("Invalid file size for %s: expected %d, got %d",
target, node.Size, fi.Size()) target, node.Size, fi.Size())