small cleanup:

- be explicit when discarding returned errors from .Close(), etc.
- remove named return values from funcs when naked return not used
- fix some "err" shadowing when redeclaration not needed
This commit is contained in:
George Armhold 2017-10-25 12:03:55 -04:00
parent 8d37b723ca
commit bcdebfb84e
8 changed files with 12 additions and 11 deletions

View file

@ -67,7 +67,7 @@ func readDirNames(dirname string) ([]string, error) {
return nil, errors.Wrap(err, "Open")
}
names, err := f.Readdirnames(-1)
f.Close()
_ = f.Close()
if err != nil {
return nil, errors.Wrap(err, "Readdirnames")
}