TrueCloudLab/restic
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

backup: reduce calls to time.Now

Browse source 
Archiver.Save queries the current time multiple times. This commit
removes one of these calls as they showed up while profiling a backup of
a nearly unchanged dataset containing 3 million files.
This commit is contained in:
Michael Eischer 2022-10-21 20:54:58 +02:00
parent 367f35db27
commit ee7c28f5e6
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/archiver/archiver.go
View file

@ -361,7 +361,6 @@ func (arch *Archiver) Save(ctx context.Context, snPath, target string, previous
switch { switch {
case fs.IsRegularFile(fi): case fs.IsRegularFile(fi):
debug.Log(" %v regular file", target) debug.Log(" %v regular file", target)
start := time.Now()
// check if the file has not changed before performing a fopen operation (more expensive, specially // check if the file has not changed before performing a fopen operation (more expensive, specially
// in network filesystems) // in network filesystems)
@ -440,7 +439,6 @@ func (arch *Archiver) Save(ctx context.Context, snPath, target string, previous
debug.Log(" %v dir", target) debug.Log(" %v dir", target)
snItem := snPath + "/" snItem := snPath + "/"
start := time.Now()
oldSubtree, err := arch.loadSubtree(ctx, previous) oldSubtree, err := arch.loadSubtree(ctx, previous)
if err != nil { if err != nil {
err = arch.error(abstarget, err) err = arch.error(abstarget, err)