TrueCloudLab/s3-tests
7
0
Fork 1
mirror of https://github.com/ceph/s3-tests.git synced 2024-11-25 13:47:27 +00:00
Code Issues 1 Projects Releases Packages Wiki Activity

Fix CORS tests without Origin headers

Browse source 
According to the CORS spec 6.1.1 [1] requests without an Origin header
should not return any access-control-* headers. But the current test
method expects these headers to be always present in the response. Fix
this by defaulting to None if the header is not present.

[1] https://www.w3.org/TR/cors/#resource-requests
This commit is contained in:
Gaudenz Steinlin 2017-07-24 15:52:11 +02:00
parent 425d2cd698
commit 4b553b448a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
s3tests/functional/test_s3.py
View file

@ -5760,8 +5760,8 @@ def _cors_request_and_check(func, url, headers, expect_status, expect_allow_orig
r = func(url, headers=headers) r = func(url, headers=headers)
eq(r.status_code, expect_status) eq(r.status_code, expect_status)
assert r.headers['access-control-allow-origin'] == expect_allow_origin assert r.headers.get('access-control-allow-origin', None) == expect_allow_origin
assert r.headers['access-control-allow-methods'] == expect_allow_methods assert r.headers.get('access-control-allow-methods', None) == expect_allow_methods