TrueCloudLab/s3-tests
7
0
Fork 1
mirror of https://github.com/ceph/s3-tests.git synced 2024-11-21 23:29:47 +00:00
Code Issues 1 Projects Releases Packages Wiki Activity

Merge pull request #533 from cbodley/wip-45736

Browse source 
304 Not Modified tests still expect etag header
This commit is contained in:
Ali Maredia 2024-01-11 13:59:03 -05:00 committed by GitHub
commit da91ad8bbf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
s3tests_boto3/functional/test_s3.py
View file

@ -3006,6 +3006,7 @@ def test_get_object_ifnonematch_good():
status, error_code = _get_status_and_error_code(e.response) status, error_code = _get_status_and_error_code(e.response)
assert status == 304 assert status == 304
assert e.response['Error']['Message'] == 'Not Modified' assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag
def test_get_object_ifnonematch_failed(): def test_get_object_ifnonematch_failed():
bucket_name = get_new_bucket() bucket_name = get_new_bucket()
@ -3031,6 +3032,7 @@ def test_get_object_ifmodifiedsince_failed():
client = get_client() client = get_client()
client.put_object(Bucket=bucket_name, Key='foo', Body='bar') client.put_object(Bucket=bucket_name, Key='foo', Body='bar')
response = client.get_object(Bucket=bucket_name, Key='foo') response = client.get_object(Bucket=bucket_name, Key='foo')
etag = response['ETag']
last_modified = str(response['LastModified']) last_modified = str(response['LastModified'])
last_modified = last_modified.split('+')[0] last_modified = last_modified.split('+')[0]
@ -3045,6 +3047,7 @@ def test_get_object_ifmodifiedsince_failed():
status, error_code = _get_status_and_error_code(e.response) status, error_code = _get_status_and_error_code(e.response)
assert status == 304 assert status == 304
assert e.response['Error']['Message'] == 'Not Modified' assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag
@pytest.mark.fails_on_dbstore @pytest.mark.fails_on_dbstore
def test_get_object_ifunmodifiedsince_good(): def test_get_object_ifunmodifiedsince_good():