scenarios: Unify logs in verify script #64

fyrchik · 2023-05-23T08:46:19Z

fyrchik commented

2023-05-23 08:46:19 +00:00

Close #63.
Close #62.
Close #27.
Close #66.

Close #63. Close #62. Close #27. Close #66.

fyrchik referenced this pull request

2023-05-23 08:47:08 +00:00

Error in verify process doesn't contain container ID #60

fyrchik changed title from ~~[#63] scenarios: Unify logs in verify script~~ to scenarios: Unify logs in verify script

2023-05-23 08:47:14 +00:00

fyrchik requested review from storage-core-committers 2023-05-23 08:47:30 +00:00

fyrchik requested review from storage-core-developers 2023-05-23 08:47:30 +00:00

fyrchik requested review from storage-services-committers 2023-05-23 08:47:30 +00:00

fyrchik requested review from storage-services-developers 2023-05-23 08:47:31 +00:00

fyrchik requested review from anikeev-yadro 2023-05-23 08:47:38 +00:00

fyrchik requested review from abereziny 2023-05-23 08:47:39 +00:00

fyrchik requested review from vdomnich-yadro 2023-05-23 08:47:39 +00:00

fyrchik force-pushed verify-logs from 954f0e7e9a to ece55e7f49

2023-05-23 08:51:29 +00:00

Compare

acid-ant approved these changes 2023-05-23 08:53:39 +00:00

fyrchik force-pushed verify-logs from ece55e7f49 to 7d02136502

2023-05-23 09:18:03 +00:00

Compare

abereziny reviewed 2023-05-23 11:35:11 +00:00

internal/registry/obj_registry.go Outdated

													
				@ -85,3 +86,4 @@

						if objBytes == nil {

							return errors.New("object doesn't exist")

						}

						if err := oldB.Delete(key); err != nil {

abereziny commented

2023-05-23 11:35:11 +00:00

What this do and for?

vdomnich-yadro commented

2023-05-23 12:23:13 +00:00

I suppose it removes object from old bucket, because the object now should belong to the bucket of new status...

fyrchik commented

2023-05-23 13:03:50 +00:00

Poster

Exactly, object must be stored in exactly one bucket, according to its status.

vdomnich-yadro reviewed 2023-05-23 12:27:06 +00:00

scenarios/verify.js Outdated

													
				@ -113,1 +118,4 @@

				        let result;

				        // Different name is required.

				        // ReferenceError: Cannot access a variable before initialization.

				        let lg = log;

vdomnich-yadro commented

2023-05-23 12:27:06 +00:00

Optional: I would name the variable as objLog, because we extend the "common" log with object-specific attributes. And comment above probably won't be needed)

Optional: I would name the variable as `objLog`, because we extend the "common" log with object-specific attributes. And comment above probably won't be needed)