From af7db13d518e6b480647de880239a7dba7032d20 Mon Sep 17 00:00:00 2001 From: Aleksey Savchuk Date: Wed, 16 Oct 2024 17:48:48 +0300 Subject: [PATCH] [#124] Makefile: Add `lint-install` target Signed-off-by: Aleksey Savchuk --- .pre-commit-config.yaml | 9 ++++++--- Makefile | 28 ++++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d20db47..3c2151e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -36,7 +36,10 @@ repos: types: [go] language: system - - repo: https://github.com/golangci/golangci-lint - rev: v1.60.3 + - repo: local hooks: - - id: golangci-lint + - id: make-lint + name: Run Make Lint + entry: make lint + language: system + pass_filenames: false diff --git a/Makefile b/Makefile index abcabc7..6176316 100755 --- a/Makefile +++ b/Makefile @@ -8,13 +8,18 @@ PROTOC_OS_VERSION=osx-x86_64 ifeq ($(shell uname), Linux) PROTOC_OS_VERSION=linux-x86_64 endif +LINT_VERSION ?= 1.60.3 +TRUECLOUDLAB_LINT_VERSION ?= 0.0.7 BIN = bin PROTOBUF_DIR ?= $(abspath $(BIN))/protobuf PROTOC_DIR ?= $(PROTOBUF_DIR)/protoc-v$(PROTOC_VERSION) PROTOC_GEN_GO_DIR ?= $(PROTOBUF_DIR)/protoc-gen-go-$(PROTOC_GEN_GO_VERSION) +OUTPUT_LINT_DIR ?= $(abspath $(BIN))/linters +LINT_DIR = $(OUTPUT_LINT_DIR)/golangci-lint-$(LINT_VERSION)-v$(TRUECLOUDLAB_LINT_VERSION) +TMP_DIR := .cache -.PHONY: dep fmts fumpt imports protoc test lint version help $(BIN)/protogen protoc-test +.PHONY: dep fmts fumpt imports protoc test version help $(BIN)/protogen protoc-test # Pull go dependencies dep: @@ -92,9 +97,28 @@ test: @echo "⇒ Running go test" @GOFLAGS="$(GOFLAGS)" go test ./... + +.PHONY: lint-install lint + +# Install linters +lint-install: + @rm -rf $(OUTPUT_LINT_DIR) + @mkdir $(OUTPUT_LINT_DIR) + @mkdir -p $(TMP_DIR) + @rm -rf $(TMP_DIR)/linters + @git -c advice.detachedHead=false clone --branch v$(TRUECLOUDLAB_LINT_VERSION) https://git.frostfs.info/TrueCloudLab/linters.git $(TMP_DIR)/linters + @@make -C $(TMP_DIR)/linters lib CGO_ENABLED=1 OUT_DIR=$(OUTPUT_LINT_DIR) + @rm -rf $(TMP_DIR)/linters + @rmdir $(TMP_DIR) 2>/dev/null || true + @CGO_ENABLED=1 GOBIN=$(LINT_DIR) go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint@v$(LINT_VERSION) + # Run linters lint: - @golangci-lint run + @if [ ! -d "$(LINT_DIR)" ]; then \ + make lint-install; \ + fi + $(LINT_DIR)/golangci-lint run + # Print version version: