forked from TrueCloudLab/frostfs-node
25391111ad
Values of object attributes must not be empty according to NeoFS specification. Make `FormatValidator.Validate` method to return an error if at least one attribute has empty value. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
275 lines
6.3 KiB
Go
275 lines
6.3 KiB
Go
package object
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/ecdsa"
|
|
"crypto/elliptic"
|
|
"errors"
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
|
|
"github.com/nspcc-dev/neofs-api-go/pkg/object"
|
|
"github.com/nspcc-dev/neofs-api-go/pkg/owner"
|
|
"github.com/nspcc-dev/neofs-api-go/pkg/storagegroup"
|
|
objectV2 "github.com/nspcc-dev/neofs-api-go/v2/object"
|
|
"github.com/nspcc-dev/neofs-node/pkg/core/netmap"
|
|
)
|
|
|
|
// FormatValidator represents object format validator.
|
|
type FormatValidator struct {
|
|
*cfg
|
|
}
|
|
|
|
// FormatValidatorOption represents FormatValidator constructor option.
|
|
type FormatValidatorOption func(*cfg)
|
|
|
|
type cfg struct {
|
|
deleteHandler DeleteHandler
|
|
|
|
netState netmap.State
|
|
}
|
|
|
|
// DeleteHandler is an interface of delete queue processor.
|
|
type DeleteHandler interface {
|
|
DeleteObjects(*object.Address, ...*object.Address)
|
|
}
|
|
|
|
var errNilObject = errors.New("object is nil")
|
|
|
|
var errNilID = errors.New("missing identifier")
|
|
|
|
var errNilCID = errors.New("missing container identifier")
|
|
|
|
var errNoExpirationEpoch = errors.New("missing expiration epoch attribute")
|
|
|
|
var errTombstoneExpiration = errors.New("tombstone body and header contain different expiration values")
|
|
|
|
func defaultCfg() *cfg {
|
|
return new(cfg)
|
|
}
|
|
|
|
// NewFormatValidator creates, initializes and returns FormatValidator instance.
|
|
func NewFormatValidator(opts ...FormatValidatorOption) *FormatValidator {
|
|
cfg := defaultCfg()
|
|
|
|
for i := range opts {
|
|
opts[i](cfg)
|
|
}
|
|
|
|
return &FormatValidator{
|
|
cfg: cfg,
|
|
}
|
|
}
|
|
|
|
// Validate validates object format.
|
|
//
|
|
// Does not validate payload checksum and content.
|
|
//
|
|
// Returns nil error if object has valid structure.
|
|
func (v *FormatValidator) Validate(obj *Object) error {
|
|
if obj == nil {
|
|
return errNilObject
|
|
} else if obj.ID() == nil {
|
|
return errNilID
|
|
} else if obj.ContainerID() == nil {
|
|
return errNilCID
|
|
}
|
|
|
|
for ; obj != nil; obj = obj.GetParent() {
|
|
if err := v.checkAttributes(obj); err != nil {
|
|
return fmt.Errorf("invalid attributes: %w", err)
|
|
}
|
|
|
|
if err := v.validateSignatureKey(obj); err != nil {
|
|
return fmt.Errorf("(%T) could not validate signature key: %w", v, err)
|
|
}
|
|
|
|
// TODO: combine small checks
|
|
if err := v.checkExpiration(obj); err != nil {
|
|
return fmt.Errorf("object did not pass expiration check: %w", err)
|
|
}
|
|
|
|
if err := object.CheckHeaderVerificationFields(obj.SDK()); err != nil {
|
|
return fmt.Errorf("(%T) could not validate header fields: %w", v, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (v *FormatValidator) validateSignatureKey(obj *Object) error {
|
|
token := obj.SessionToken()
|
|
key := obj.Signature().Key()
|
|
|
|
if token == nil || !bytes.Equal(token.SessionKey(), key) {
|
|
return v.checkOwnerKey(obj.OwnerID(), obj.Signature().Key())
|
|
}
|
|
|
|
// FIXME: perform token verification
|
|
|
|
return nil
|
|
}
|
|
|
|
func (v *FormatValidator) checkOwnerKey(id *owner.ID, key []byte) error {
|
|
pub, err := keys.NewPublicKeyFromBytes(key, elliptic.P256())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
wallet, err := owner.NEO3WalletFromPublicKey((*ecdsa.PublicKey)(pub))
|
|
if err != nil {
|
|
// TODO: check via NeoFSID
|
|
return err
|
|
}
|
|
|
|
id2 := owner.NewID()
|
|
id2.SetNeo3Wallet(wallet)
|
|
|
|
if !id.Equal(id2) {
|
|
return fmt.Errorf("(%T) different owner identifiers %s/%s", v, id, id2)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ValidateContent validates payload content according to object type.
|
|
func (v *FormatValidator) ValidateContent(o *Object) error {
|
|
switch o.Type() {
|
|
case object.TypeTombstone:
|
|
if len(o.Payload()) == 0 {
|
|
return fmt.Errorf("(%T) empty payload in tombstone", v)
|
|
}
|
|
|
|
tombstone := object.NewTombstone()
|
|
|
|
if err := tombstone.Unmarshal(o.Payload()); err != nil {
|
|
return fmt.Errorf("(%T) could not unmarshal tombstone content: %w", v, err)
|
|
}
|
|
|
|
// check if tombstone has the same expiration in body and header
|
|
exp, err := expirationEpochAttribute(o)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if exp != tombstone.ExpirationEpoch() {
|
|
return errTombstoneExpiration
|
|
}
|
|
|
|
// mark all objects from tombstone body as removed in storage engine
|
|
cid := o.ContainerID()
|
|
idList := tombstone.Members()
|
|
addrList := make([]*object.Address, 0, len(idList))
|
|
|
|
for _, id := range idList {
|
|
if id == nil {
|
|
return fmt.Errorf("(%T) empty member in tombstone", v)
|
|
}
|
|
|
|
a := object.NewAddress()
|
|
a.SetContainerID(cid)
|
|
a.SetObjectID(id)
|
|
|
|
addrList = append(addrList, a)
|
|
}
|
|
|
|
if v.deleteHandler != nil {
|
|
v.deleteHandler.DeleteObjects(o.Address(), addrList...)
|
|
}
|
|
case object.TypeStorageGroup:
|
|
if len(o.Payload()) == 0 {
|
|
return fmt.Errorf("(%T) empty payload in SG", v)
|
|
}
|
|
|
|
sg := storagegroup.New()
|
|
|
|
if err := sg.Unmarshal(o.Payload()); err != nil {
|
|
return fmt.Errorf("(%T) could not unmarshal SG content: %w", v, err)
|
|
}
|
|
|
|
for _, id := range sg.Members() {
|
|
if id == nil {
|
|
return fmt.Errorf("(%T) empty member in SG", v)
|
|
}
|
|
}
|
|
default:
|
|
// ignore all other object types, they do not need payload formatting
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
var errExpired = errors.New("object has expired")
|
|
|
|
func (v *FormatValidator) checkExpiration(obj *Object) error {
|
|
exp, err := expirationEpochAttribute(obj)
|
|
if err != nil {
|
|
if errors.Is(err, errNoExpirationEpoch) {
|
|
return nil // objects without expiration attribute are valid
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
if exp < v.netState.CurrentEpoch() {
|
|
return errExpired
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func expirationEpochAttribute(obj *Object) (uint64, error) {
|
|
for _, a := range obj.Attributes() {
|
|
if a.Key() != objectV2.SysAttributeExpEpoch {
|
|
continue
|
|
}
|
|
|
|
return strconv.ParseUint(a.Value(), 10, 64)
|
|
}
|
|
|
|
return 0, errNoExpirationEpoch
|
|
}
|
|
|
|
var (
|
|
errDuplAttr = errors.New("duplication of attributes detected")
|
|
errEmptyAttrVal = errors.New("empty attribute value")
|
|
)
|
|
|
|
func (v *FormatValidator) checkAttributes(obj *Object) error {
|
|
as := obj.Attributes()
|
|
|
|
mUnique := make(map[string]struct{}, len(as))
|
|
|
|
for _, a := range as {
|
|
key := a.Key()
|
|
|
|
if _, was := mUnique[key]; was {
|
|
return errDuplAttr
|
|
}
|
|
|
|
if a.Value() == "" {
|
|
return errEmptyAttrVal
|
|
}
|
|
|
|
mUnique[key] = struct{}{}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// WithNetState returns options to set network state interface.
|
|
//
|
|
// FIXME: network state is a required parameter.
|
|
func WithNetState(netState netmap.State) FormatValidatorOption {
|
|
return func(c *cfg) {
|
|
c.netState = netState
|
|
}
|
|
}
|
|
|
|
// WithDeleteHandler returns option to set delete queue processor.
|
|
func WithDeleteHandler(v DeleteHandler) FormatValidatorOption {
|
|
return func(c *cfg) {
|
|
c.deleteHandler = v
|
|
}
|
|
}
|