aarifullin/frostfs-api-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-api-go
Code Pull requests Activity

[#307] v2/session/test: Do not allocate memory if !empty

Browse source 
Move all memory allocation and field settings
in `Generate...(empty bool)` functions behind
`if !empty` check. Do not create empty slices
if `empty == true`.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This commit is contained in:
Pavel Karpy 2021-06-11 15:44:16 +03:00 committed by Alex Vanin
parent 704d16c6c6
commit 383edb1be4
1 changed files with 27 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
v2/session/test/generate.go
View file

@ -11,17 +11,19 @@ func GenerateCreateRequestBody(empty bool) *session.CreateRequestBody {
if !empty {
m.SetExpiration(555)
m.SetOwnerID(refstest.GenerateOwnerID(false))
}
m.SetOwnerID(refstest.GenerateOwnerID(empty))
return m
}
func GenerateCreateRequest(empty bool) *session.CreateRequest {
m := new(session.CreateRequest)
m.SetBody(GenerateCreateRequestBody(empty))
if !empty {
m.SetBody(GenerateCreateRequestBody(false))
}
m.SetMetaHeader(GenerateRequestMetaHeader(empty))
m.SetVerificationHeader(GenerateRequestVerificationHeader(empty))
@ -42,7 +44,10 @@ func GenerateCreateResponseBody(empty bool) *session.CreateResponseBody {
func GenerateCreateResponse(empty bool) *session.CreateResponse {
m := new(session.CreateResponse)
m.SetBody(GenerateCreateResponseBody(empty))
if !empty {
m.SetBody(GenerateCreateResponseBody(false))
}
m.SetMetaHeader(GenerateResponseMetaHeader(empty))
m.SetVerificationHeader(GenerateResponseVerificationHeader(empty))
@ -56,7 +61,10 @@ func GenerateResponseVerificationHeader(empty bool) *session.ResponseVerificatio
func generateResponseVerificationHeader(empty, withOrigin bool) *session.ResponseVerificationHeader {
m := new(session.ResponseVerificationHeader)
m.SetBodySignature(refstest.GenerateSignature(empty))
if !empty {
m.SetBodySignature(refstest.GenerateSignature(false))
}
m.SetMetaSignature(refstest.GenerateSignature(empty))
m.SetOriginSignature(refstest.GenerateSignature(empty))
@ -96,7 +104,10 @@ func GenerateRequestVerificationHeader(empty bool) *session.RequestVerificationH
func generateRequestVerificationHeader(empty, withOrigin bool) *session.RequestVerificationHeader {
m := new(session.RequestVerificationHeader)
m.SetBodySignature(refstest.GenerateSignature(empty))
if !empty {
m.SetBodySignature(refstest.GenerateSignature(false))
}
m.SetMetaSignature(refstest.GenerateSignature(empty))
m.SetOriginSignature(refstest.GenerateSignature(empty))
@ -134,7 +145,10 @@ func generateRequestMetaHeader(empty, withOrigin bool) *session.RequestMetaHeade
func GenerateSessionToken(empty bool) *session.SessionToken {
m := new(session.SessionToken)
m.SetBody(GenerateSessionTokenBody(empty))
if !empty {
m.SetBody(GenerateSessionTokenBody(false))
}
m.SetSignature(refstest.GenerateSignature(empty))
return m
@ -146,12 +160,11 @@ func GenerateSessionTokenBody(empty bool) *session.SessionTokenBody {
if !empty {
m.SetID([]byte{1})
m.SetSessionKey([]byte{2})
m.SetOwnerID(refstest.GenerateOwnerID(false))
m.SetLifetime(GenerateTokenLifetime(false))
m.SetContext(GenerateObjectSessionContext(false))
}
m.SetOwnerID(refstest.GenerateOwnerID(empty))
m.SetLifetime(GenerateTokenLifetime(empty))
m.SetContext(GenerateObjectSessionContext(empty))
return m
}
@ -172,10 +185,9 @@ func GenerateObjectSessionContext(empty bool) *session.ObjectSessionContext {
if !empty {
m.SetVerb(session.ObjectVerbHead)
m.SetAddress(refstest.GenerateAddress(false))
}
m.SetAddress(refstest.GenerateAddress(empty))
return m
}
@ -185,10 +197,9 @@ func GenerateContainerSessionContext(empty bool) *session.ContainerSessionContex
if !empty {
m.SetVerb(session.ContainerVerbDelete)
m.SetWildcard(true)
m.SetContainerID(refstest.GenerateContainerID(false))
}
m.SetContainerID(refstest.GenerateContainerID(empty))
return m
}
@ -204,7 +215,7 @@ func GenerateXHeader(empty bool) *session.XHeader {
}
func GenerateXHeaders(empty bool) []*session.XHeader {
xs := make([]*session.XHeader, 0)
var xs []*session.XHeader
if !empty {
xs = append(xs,