From af1742b48a99842193ed70a99e6a54442bf3df77 Mon Sep 17 00:00:00 2001 From: Pavel Karpy Date: Tue, 8 Jun 2021 18:29:16 +0300 Subject: [PATCH] [#302] pkg/netmap: Document default values set in `NewReplica` Document field values of instance constructed via `NewReplica`. Assert the values in corresponding unit test. Signed-off-by: Pavel Karpy --- pkg/netmap/replica.go | 4 ++++ pkg/netmap/replica_test.go | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/pkg/netmap/replica.go b/pkg/netmap/replica.go index b9bae5d..9bceb7f 100644 --- a/pkg/netmap/replica.go +++ b/pkg/netmap/replica.go @@ -8,6 +8,10 @@ import ( type Replica netmap.Replica // NewReplica creates and returns new Replica instance. +// +// Defaults: +// - count: 0; +// - selector: "". func NewReplica() *Replica { return NewReplicaFromV2(new(netmap.Replica)) } diff --git a/pkg/netmap/replica_test.go b/pkg/netmap/replica_test.go index 9c6d5a9..c1b0dba 100644 --- a/pkg/netmap/replica_test.go +++ b/pkg/netmap/replica_test.go @@ -81,3 +81,19 @@ func TestReplica_ToV2(t *testing.T) { require.Nil(t, x.ToV2()) }) } + +func TestNewReplica(t *testing.T) { + t.Run("default values", func(t *testing.T) { + r := NewReplica() + + // check initial values + require.Zero(t, r.Count()) + require.Empty(t, r.Selector()) + + // convert to v2 message + rV2 := r.ToV2() + + require.Zero(t, rV2.GetCount()) + require.Empty(t, rV2.GetSelector()) + }) +}