forked from TrueCloudLab/frostfs-contract
[#59] proxy: Check committee address in Verify function
For committee operations in side chain we can't use 5\7 multi address, instead we should use 4\7 for this case. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
parent
8af80e67aa
commit
7ba5d50fd4
4 changed files with 32 additions and 4 deletions
15
common/ir.go
15
common/ir.go
|
@ -10,6 +10,7 @@ import (
|
|||
const (
|
||||
irListMethod = "innerRingList"
|
||||
multiaddrMethod = "multiaddress"
|
||||
committeeMethod = "committee"
|
||||
)
|
||||
|
||||
type IRNode struct {
|
||||
|
@ -56,3 +57,17 @@ func InnerRingMultiAddressViaStorage(ctx storage.Context, key interface{}) []byt
|
|||
func InnerRingMultiAddress(sc interop.Hash160) []byte {
|
||||
return contract.Call(sc, multiaddrMethod, contract.ReadOnly).([]byte)
|
||||
}
|
||||
|
||||
// CommitteeMultiAddressViaStorage returns multiaddress of committee public
|
||||
// keys by invoking netmap contract, which scripthash stored in the contract
|
||||
// storage by the key `key`.
|
||||
func CommitteeMultiAddressViaStorage(ctx storage.Context, key interface{}) []byte {
|
||||
sc := storage.Get(ctx, key).(interop.Hash160)
|
||||
return CommitteeMultiAddress(sc)
|
||||
}
|
||||
|
||||
// CommitteeMultiAddress returns multiaddress of committee public keys by
|
||||
// invoking netmap contract.
|
||||
func CommitteeMultiAddress(sc interop.Hash160) []byte {
|
||||
return contract.Call(sc, committeeMethod, contract.ReadOnly).([]byte)
|
||||
}
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
name: "NeoFS Netmap"
|
||||
safemethods: ["innerRingList", "multiaddress", "epoch", "netmap", "snapshot", "snapshotByEpoch", "config", "listConfig", "version"]
|
||||
safemethods: ["innerRingList", "multiaddress", "committee", "epoch", "netmap", "snapshot", "snapshotByEpoch", "config", "listConfig", "version"]
|
||||
events:
|
||||
- name: AddPeer
|
||||
parameters:
|
||||
|
|
|
@ -103,7 +103,12 @@ func InnerRingList() []common.IRNode {
|
|||
|
||||
func Multiaddress() []byte {
|
||||
ctx := storage.GetReadOnlyContext()
|
||||
return multiaddress(getIRNodes(ctx))
|
||||
return multiaddress(getIRNodes(ctx), false)
|
||||
}
|
||||
|
||||
func Committee() []byte {
|
||||
ctx := storage.GetReadOnlyContext()
|
||||
return multiaddress(getIRNodes(ctx), true)
|
||||
}
|
||||
|
||||
func UpdateInnerRing(keys []interop.PublicKey) bool {
|
||||
|
@ -420,8 +425,11 @@ func setConfig(ctx storage.Context, key, val interface{}) {
|
|||
storage.Put(ctx, storageKey, val)
|
||||
}
|
||||
|
||||
func multiaddress(n []common.IRNode) []byte {
|
||||
func multiaddress(n []common.IRNode, committee bool) []byte {
|
||||
threshold := len(n)/3*2 + 1
|
||||
if committee {
|
||||
threshold = len(n)/2 + 1
|
||||
}
|
||||
|
||||
var result = []byte{0x10 + uint8(threshold)} // m value = 5
|
||||
|
||||
|
|
|
@ -57,9 +57,14 @@ func Verify() bool {
|
|||
ctx := storage.GetReadOnlyContext()
|
||||
sig := common.InnerRingMultiAddressViaStorage(ctx, netmapContractKey)
|
||||
|
||||
if !runtime.CheckWitness(sig) {
|
||||
sig = common.CommitteeMultiAddressViaStorage(ctx, netmapContractKey)
|
||||
return runtime.CheckWitness(sig)
|
||||
}
|
||||
|
||||
return true
|
||||
}
|
||||
|
||||
func Version() int {
|
||||
return version
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue