aarifullin/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Issues Pull requests Projects Releases Packages Wiki Activity

[#424] metrics: Drop unused arg

Browse source 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2023-06-13 15:03:37 +03:00
parent fb8fee0c8e
commit 71bbeddb64
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/metrics/morphcache.go
View file

@ -6,7 +6,6 @@ import (
"time" "time"
"git.frostfs.info/TrueCloudLab/frostfs-observability/metrics" "git.frostfs.info/TrueCloudLab/frostfs-observability/metrics"
"github.com/nspcc-dev/neo-go/pkg/util"
"github.com/prometheus/client_golang/prometheus" "github.com/prometheus/client_golang/prometheus"
) )
@ -20,7 +19,7 @@ type MorphCacheMetrics interface {
AddGroupKeyDuration(success bool, d time.Duration) AddGroupKeyDuration(success bool, d time.Duration)
AddTxHeightDuration(hash util.Uint256, success bool, d time.Duration) AddTxHeightDuration(success bool, d time.Duration)
} }
type morphCacheMetrics struct { type morphCacheMetrics struct {
@ -60,7 +59,7 @@ func (m *morphCacheMetrics) AddGroupKeyDuration(success bool, d time.Duration) {
).Observe(float64(d)) ).Observe(float64(d))
} }
func (m *morphCacheMetrics) AddTxHeightDuration(hash util.Uint256, success bool, d time.Duration) { func (m *morphCacheMetrics) AddTxHeightDuration(success bool, d time.Duration) {
m.txHeightDuration.With( m.txHeightDuration.With(
prometheus.Labels{ prometheus.Labels{
mcSuccess: strconv.FormatBool(success), mcSuccess: strconv.FormatBool(success),

2
pkg/morph/client/notary.go
View file

@ -800,7 +800,7 @@ func (c *Client) getTransactionHeight(h util.Uint256) (uint32, error) {
success := false success := false
startedAt := time.Now() startedAt := time.Now()
defer func() { defer func() {
c.cache.metrics.AddTxHeightDuration(h, success, time.Since(startedAt)) c.cache.metrics.AddTxHeightDuration(success, time.Since(startedAt))
}() }()
if rh, ok := c.cache.txHeights.Get(h); ok { if rh, ok := c.cache.txHeights.Get(h); ok {