From ae9207427286fe33601e1d17fc878a8d14e22987 Mon Sep 17 00:00:00 2001
From: Leonard Lyubich <leonard@nspcc.ru>
Date: Wed, 11 May 2022 19:35:01 +0300
Subject: [PATCH] [#1369] checksum: Upgrade SDK package

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
---
 cmd/neofs-cli/modules/object.go               |  30 ++++++++++++++----
 cmd/neofs-cli/modules/storagegroup.go         |   2 +-
 go.mod                                        |   2 +-
 go.sum                                        | Bin 98064 -> 98319 bytes
 .../engine/engine_test.go                     |   6 ++--
 pkg/local_object_storage/metabase/db_test.go  |   6 ++--
 pkg/local_object_storage/metabase/put.go      |   4 ++-
 pkg/local_object_storage/metabase/select.go   |   3 +-
 .../metabase/select_test.go                   |  12 ++++---
 pkg/local_object_storage/shard/shard_test.go  |   6 ++--
 pkg/services/audit/auditor/context.go         |   4 ++-
 pkg/services/audit/auditor/por.go             |  12 +++----
 pkg/services/object/acl/eacl/v2/object.go     |  26 +++++++++------
 pkg/services/object/put/validation.go         |   8 +++--
 .../object_manager/storagegroup/collect.go    |   5 +--
 .../object_manager/transformer/transformer.go |  24 +++++++-------
 16 files changed, 94 insertions(+), 56 deletions(-)

diff --git a/cmd/neofs-cli/modules/object.go b/cmd/neofs-cli/modules/object.go
index cccf76e3..c16d115a 100644
--- a/cmd/neofs-cli/modules/object.go
+++ b/cmd/neofs-cli/modules/object.go
@@ -681,15 +681,20 @@ func getObjectHash(cmd *cobra.Command, _ []string) {
 		res, err := internalclient.HeadObject(headPrm)
 		exitOnErr(cmd, errf("rpc error: %w", err))
 
-		var cs *checksum.Checksum
+		var cs checksum.Checksum
+		var csSet bool
 
 		if tz {
-			cs = res.Header().PayloadHomomorphicHash()
+			cs, csSet = res.Header().PayloadHomomorphicHash()
 		} else {
-			cs = res.Header().PayloadChecksum()
+			cs, csSet = res.Header().PayloadChecksum()
 		}
 
-		cmd.Println(hex.EncodeToString(cs.Sum()))
+		if csSet {
+			cmd.Println(hex.EncodeToString(cs.Value()))
+		} else {
+			cmd.Println("Missing checksum in object header.")
+		}
 
 		return
 	}
@@ -959,14 +964,27 @@ func saveAndPrintHeader(cmd *cobra.Command, obj *object.Object, filename string)
 	return printHeader(cmd, obj)
 }
 
+func printChecksum(cmd *cobra.Command, name string, recv func() (checksum.Checksum, bool)) {
+	var strVal string
+
+	cs, csSet := recv()
+	if csSet {
+		strVal = hex.EncodeToString(cs.Value())
+	} else {
+		strVal = "<empty>"
+	}
+
+	cmd.Printf("%s: %s\n", name, strVal)
+}
+
 func printHeader(cmd *cobra.Command, obj *object.Object) error {
 	cmd.Printf("ID: %s\n", obj.ID())
 	cmd.Printf("CID: %s\n", obj.ContainerID())
 	cmd.Printf("Owner: %s\n", obj.OwnerID())
 	cmd.Printf("CreatedAt: %d\n", obj.CreationEpoch())
 	cmd.Printf("Size: %d\n", obj.PayloadSize())
-	cmd.Printf("HomoHash: %s\n", hex.EncodeToString(obj.PayloadHomomorphicHash().Sum()))
-	cmd.Printf("Checksum: %s\n", hex.EncodeToString(obj.PayloadChecksum().Sum()))
+	printChecksum(cmd, "HomoHash", obj.PayloadHomomorphicHash)
+	printChecksum(cmd, "Checksum", obj.PayloadChecksum)
 	cmd.Printf("Type: %s\n", obj.Type())
 
 	cmd.Println("Attributes:")
diff --git a/cmd/neofs-cli/modules/storagegroup.go b/cmd/neofs-cli/modules/storagegroup.go
index ec773957..cf8b263e 100644
--- a/cmd/neofs-cli/modules/storagegroup.go
+++ b/cmd/neofs-cli/modules/storagegroup.go
@@ -255,7 +255,7 @@ func getSG(cmd *cobra.Command, _ []string) {
 
 	cmd.Printf("Expiration epoch: %d\n", sg.ExpirationEpoch())
 	cmd.Printf("Group size: %d\n", sg.ValidationDataSize())
-	cmd.Printf("Group hash: %s\n", sg.ValidationDataHash())
+	printChecksum(cmd, "Group hash", sg.ValidationDataHash)
 
 	if members := sg.Members(); len(members) > 0 {
 		cmd.Println("Members:")
diff --git a/go.mod b/go.mod
index a27e6b32..9edabaab 100644
--- a/go.mod
+++ b/go.mod
@@ -19,7 +19,7 @@ require (
 	github.com/nspcc-dev/neo-go/pkg/interop v0.0.0-20220321144137-d5a9af5860af // indirect
 	github.com/nspcc-dev/neofs-api-go/v2 v2.12.1
 	github.com/nspcc-dev/neofs-contract v0.14.2
-	github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.3.0.20220413072812-c961aea14446
+	github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.3.0.20220413075357-96892d7bc4a8
 	github.com/nspcc-dev/tzhash v1.5.2
 	github.com/panjf2000/ants/v2 v2.4.0
 	github.com/paulmach/orb v0.2.2
diff --git a/go.sum b/go.sum
index 9f2816c52b9e3baec65b30867f6df5d2803ef08c..909203424cd24c721634ca1d00a7346a079b4cf7 100644
GIT binary patch
delta 175
zcmbR6kF~#nZG+pK$^NtWCWp=zcQ7?JHP^K?v#>NuF;7Z1NwiSNFtpOo3o|t@wsZ~j
zxA2Pa_we&E3H2<q$O|zyEAulouM7yWOmt3l4k)hjNuRuNqBzVjcMQYy)ARLm^HV@(
zCI@<_<P=%D=N6b|RV4X)nOg*#8=7PqI#wp9MTS-tgr%fZgoV18ScLn6%-rlY=hPzr
DlL0!w

delta 18
acmeBgV4Ludb%WcS$qVLkZw{Ed{}BLEoe5U}

diff --git a/pkg/local_object_storage/engine/engine_test.go b/pkg/local_object_storage/engine/engine_test.go
index 04b3faca..07b97468 100644
--- a/pkg/local_object_storage/engine/engine_test.go
+++ b/pkg/local_object_storage/engine/engine_test.go
@@ -152,11 +152,11 @@ func generateObjectWithCID(t testing.TB, cid *cid.ID) *object.Object {
 	ver.SetMajor(2)
 	ver.SetMinor(1)
 
-	csum := new(checksum.Checksum)
+	var csum checksum.Checksum
 	csum.SetSHA256(sha256.Sum256(owner.PublicKeyToIDBytes(&test.DecodeKey(-1).PublicKey)))
 
-	csumTZ := new(checksum.Checksum)
-	csumTZ.SetTillichZemor(tz.Sum(csum.Sum()))
+	var csumTZ checksum.Checksum
+	csumTZ.SetTillichZemor(tz.Sum(csum.Value()))
 
 	obj := object.New()
 	obj.SetID(testOID())
diff --git a/pkg/local_object_storage/metabase/db_test.go b/pkg/local_object_storage/metabase/db_test.go
index a4f15344..a7e9d2f1 100644
--- a/pkg/local_object_storage/metabase/db_test.go
+++ b/pkg/local_object_storage/metabase/db_test.go
@@ -72,11 +72,11 @@ func generateObjectWithCID(t testing.TB, cid *cid.ID) *object.Object {
 	ver.SetMajor(2)
 	ver.SetMinor(1)
 
-	csum := new(checksum.Checksum)
+	var csum checksum.Checksum
 	csum.SetSHA256(sha256.Sum256(owner.PublicKeyToIDBytes(&test.DecodeKey(-1).PublicKey)))
 
-	csumTZ := new(checksum.Checksum)
-	csumTZ.SetTillichZemor(tz.Sum(csum.Sum()))
+	var csumTZ checksum.Checksum
+	csumTZ.SetTillichZemor(tz.Sum(csum.Value()))
 
 	obj := object.New()
 	obj.SetID(testOID())
diff --git a/pkg/local_object_storage/metabase/put.go b/pkg/local_object_storage/metabase/put.go
index 527ece1e..c3ca1a45 100644
--- a/pkg/local_object_storage/metabase/put.go
+++ b/pkg/local_object_storage/metabase/put.go
@@ -247,10 +247,12 @@ func updateListIndexes(tx *bbolt.Tx, obj *objectSDK.Object, f updateIndexItemFun
 	addr := object.AddressOf(obj)
 	objKey := objectKey(addr.ObjectID())
 
+	cs, _ := obj.PayloadChecksum()
+
 	// index payload hashes
 	err := f(tx, namedBucketItem{
 		name: payloadHashBucketName(addr.ContainerID()),
-		key:  obj.PayloadChecksum().Sum(),
+		key:  cs.Value(),
 		val:  objKey,
 	})
 	if err != nil {
diff --git a/pkg/local_object_storage/metabase/select.go b/pkg/local_object_storage/metabase/select.go
index 2431ddb4..1dae0ba7 100644
--- a/pkg/local_object_storage/metabase/select.go
+++ b/pkg/local_object_storage/metabase/select.go
@@ -516,7 +516,8 @@ func (db *DB) matchSlowFilters(tx *bbolt.Tx, addr *addressSDK.Address, f object.
 		case v2object.FilterHeaderVersion:
 			data = []byte(obj.Version().String())
 		case v2object.FilterHeaderHomomorphicHash:
-			data = obj.PayloadHomomorphicHash().Sum()
+			cs, _ := obj.PayloadHomomorphicHash()
+			data = cs.Value()
 		case v2object.FilterHeaderCreationEpoch:
 			data = make([]byte, 8)
 			binary.LittleEndian.PutUint64(data, obj.CreationEpoch())
diff --git a/pkg/local_object_storage/metabase/select_test.go b/pkg/local_object_storage/metabase/select_test.go
index 618149f2..6aa94fe0 100644
--- a/pkg/local_object_storage/metabase/select_test.go
+++ b/pkg/local_object_storage/metabase/select_test.go
@@ -358,16 +358,18 @@ func TestDB_SelectPayloadHash(t *testing.T) {
 	err = putBig(db, raw2)
 	require.NoError(t, err)
 
+	cs, _ := raw1.PayloadChecksum()
+
 	fs := objectSDK.SearchFilters{}
 	fs.AddFilter(v2object.FilterHeaderPayloadHash,
-		hex.EncodeToString(raw1.PayloadChecksum().Sum()),
+		hex.EncodeToString(cs.Value()),
 		objectSDK.MatchStringEqual)
 
 	testSelect(t, db, cid, fs, object.AddressOf(raw1))
 
 	fs = objectSDK.SearchFilters{}
 	fs.AddFilter(v2object.FilterHeaderPayloadHash,
-		hex.EncodeToString(raw1.PayloadChecksum().Sum()),
+		hex.EncodeToString(cs.Value()),
 		objectSDK.MatchStringNotEqual)
 
 	testSelect(t, db, cid, fs, object.AddressOf(raw2))
@@ -407,16 +409,18 @@ func TestDB_SelectWithSlowFilters(t *testing.T) {
 	require.NoError(t, err)
 
 	t.Run("object with TZHash", func(t *testing.T) {
+		cs, _ := raw1.PayloadHomomorphicHash()
+
 		fs := objectSDK.SearchFilters{}
 		fs.AddFilter(v2object.FilterHeaderHomomorphicHash,
-			hex.EncodeToString(raw1.PayloadHomomorphicHash().Sum()),
+			hex.EncodeToString(cs.Value()),
 			objectSDK.MatchStringEqual)
 
 		testSelect(t, db, cid, fs, object.AddressOf(raw1))
 
 		fs = objectSDK.SearchFilters{}
 		fs.AddFilter(v2object.FilterHeaderHomomorphicHash,
-			hex.EncodeToString(raw1.PayloadHomomorphicHash().Sum()),
+			hex.EncodeToString(cs.Value()),
 			objectSDK.MatchStringNotEqual)
 
 		testSelect(t, db, cid, fs, object.AddressOf(raw2))
diff --git a/pkg/local_object_storage/shard/shard_test.go b/pkg/local_object_storage/shard/shard_test.go
index 457aef98..650638bb 100644
--- a/pkg/local_object_storage/shard/shard_test.go
+++ b/pkg/local_object_storage/shard/shard_test.go
@@ -86,11 +86,11 @@ func generateObjectWithPayload(cid *cid.ID, data []byte) *object.Object {
 	ver.SetMajor(2)
 	ver.SetMinor(1)
 
-	csum := new(checksum.Checksum)
+	var csum checksum.Checksum
 	csum.SetSHA256(sha256.Sum256(data))
 
-	csumTZ := new(checksum.Checksum)
-	csumTZ.SetTillichZemor(tz.Sum(csum.Sum()))
+	var csumTZ checksum.Checksum
+	csumTZ.SetTillichZemor(tz.Sum(csum.Value()))
 
 	obj := object.New()
 	obj.SetID(generateOID())
diff --git a/pkg/services/audit/auditor/context.go b/pkg/services/audit/auditor/context.go
index 068a3dc2..347d0942 100644
--- a/pkg/services/audit/auditor/context.go
+++ b/pkg/services/audit/auditor/context.go
@@ -256,9 +256,11 @@ func (c *Context) updateHeadResponses(hdr *object.Object) {
 
 	strID := hdr.ID().String()
 
+	cs, _ := hdr.PayloadHomomorphicHash()
+
 	if _, ok := c.headResponses[strID]; !ok {
 		c.headResponses[strID] = shortHeader{
-			tzhash:     hdr.PayloadHomomorphicHash().Sum(),
+			tzhash:     cs.Value(),
 			objectSize: hdr.PayloadSize(),
 		}
 	}
diff --git a/pkg/services/audit/auditor/por.go b/pkg/services/audit/auditor/por.go
index 61f4ef9b..817b96bc 100644
--- a/pkg/services/audit/auditor/por.go
+++ b/pkg/services/audit/auditor/por.go
@@ -90,13 +90,12 @@ func (c *Context) checkStorageGroupPoR(ind int, sg *oidSDK.ID) {
 			// update cache for PoR and PDP audit checks
 			c.updateHeadResponses(hdr)
 
+			cs, _ := hdr.PayloadHomomorphicHash()
+
 			if len(tzHash) == 0 {
-				tzHash = hdr.PayloadHomomorphicHash().Sum()
+				tzHash = cs.Value()
 			} else {
-				tzHash, err = tz.Concat([][]byte{
-					tzHash,
-					hdr.PayloadHomomorphicHash().Sum(),
-				})
+				tzHash, err = tz.Concat([][]byte{tzHash, cs.Value()})
 				if err != nil {
 					c.log.Debug("can't concatenate tz hash",
 						zap.String("oid", members[i].String()),
@@ -116,7 +115,8 @@ func (c *Context) checkStorageGroupPoR(ind int, sg *oidSDK.ID) {
 	c.porRetries.Add(accRetries)
 
 	sizeCheck := storageGroup.ValidationDataSize() == totalSize
-	tzCheck := bytes.Equal(tzHash, storageGroup.ValidationDataHash().Sum())
+	cs, _ := storageGroup.ValidationDataHash()
+	tzCheck := bytes.Equal(tzHash, cs.Value())
 
 	if sizeCheck && tzCheck {
 		c.report.PassedPoR(sg) // write report
diff --git a/pkg/services/object/acl/eacl/v2/object.go b/pkg/services/object/acl/eacl/v2/object.go
index 4d3daad0..16594dfe 100644
--- a/pkg/services/object/acl/eacl/v2/object.go
+++ b/pkg/services/object/acl/eacl/v2/object.go
@@ -71,23 +71,29 @@ func headersFromObject(obj *object.Object, addr *objectSDKAddress.Address) []eac
 				k: acl.FilterObjectVersion,
 				v: obj.Version().String(),
 			},
-			// payload hash
-			&sysObjHdr{
-				k: acl.FilterObjectPayloadHash,
-				v: obj.PayloadChecksum().String(),
-			},
 			// object type
 			&sysObjHdr{
 				k: acl.FilterObjectType,
 				v: obj.Type().String(),
 			},
-			// payload homomorphic hash
-			&sysObjHdr{
-				k: acl.FilterObjectHomomorphicHash,
-				v: obj.PayloadHomomorphicHash().String(),
-			},
 		)
 
+		cs, ok := obj.PayloadChecksum()
+		if ok {
+			res = append(res, &sysObjHdr{
+				k: acl.FilterObjectPayloadHash,
+				v: cs.String(),
+			})
+		}
+
+		cs, ok = obj.PayloadHomomorphicHash()
+		if ok {
+			res = append(res, &sysObjHdr{
+				k: acl.FilterObjectHomomorphicHash,
+				v: cs.String(),
+			})
+		}
+
 		attrs := obj.Attributes()
 		for i := range attrs {
 			res = append(res, &attrs[i]) // only pointer attrs can implement eaclSDK.Header interface
diff --git a/pkg/services/object/put/validation.go b/pkg/services/object/put/validation.go
index b338fb83..e17dfa73 100644
--- a/pkg/services/object/put/validation.go
+++ b/pkg/services/object/put/validation.go
@@ -54,7 +54,11 @@ func (t *validatingTarget) WriteHeader(obj *objectSDK.Object) error {
 			return ErrExceedingMaxSize
 		}
 
-		cs := obj.PayloadChecksum()
+		cs, csSet := obj.PayloadChecksum()
+		if !csSet {
+			return errors.New("missing payload checksum")
+		}
+
 		switch typ := cs.Type(); typ {
 		default:
 			return fmt.Errorf("(%T) unsupported payload checksum type %v", t, typ)
@@ -64,7 +68,7 @@ func (t *validatingTarget) WriteHeader(obj *objectSDK.Object) error {
 			t.hash = tz.New()
 		}
 
-		t.checksum = cs.Sum()
+		t.checksum = cs.Value()
 	}
 
 	if err := t.fmt.Validate(obj, t.unpreparedObject); err != nil {
diff --git a/pkg/services/object_manager/storagegroup/collect.go b/pkg/services/object_manager/storagegroup/collect.go
index eff3eaa0..1fa8058f 100644
--- a/pkg/services/object_manager/storagegroup/collect.go
+++ b/pkg/services/object_manager/storagegroup/collect.go
@@ -32,7 +32,8 @@ func CollectMembers(r objutil.HeadReceiver, cid *cid.ID, members []oidSDK.ID) (*
 		if err := objutil.IterateAllSplitLeaves(r, addr, func(leaf *object.Object) {
 			phyMembers = append(phyMembers, *leaf.ID())
 			sumPhySize += leaf.PayloadSize()
-			phyHashes = append(phyHashes, leaf.PayloadHomomorphicHash().Sum())
+			cs, _ := leaf.PayloadHomomorphicHash()
+			phyHashes = append(phyHashes, cs.Value())
 		}); err != nil {
 			return nil, err
 		}
@@ -43,7 +44,7 @@ func CollectMembers(r objutil.HeadReceiver, cid *cid.ID, members []oidSDK.ID) (*
 		return nil, err
 	}
 
-	cs := checksum.New()
+	var cs checksum.Checksum
 	tzHash := [64]byte{}
 	copy(tzHash[:], sumHash)
 	cs.SetTillichZemor(tzHash)
diff --git a/pkg/services/object_manager/transformer/transformer.go b/pkg/services/object_manager/transformer/transformer.go
index 2f417aa2..4d2ee3dc 100644
--- a/pkg/services/object_manager/transformer/transformer.go
+++ b/pkg/services/object_manager/transformer/transformer.go
@@ -128,34 +128,34 @@ func payloadHashersForObject(obj *object.Object) []*payloadChecksumHasher {
 	return []*payloadChecksumHasher{
 		{
 			hasher: sha256.New(),
-			checksumWriter: func(cs []byte) {
-				if ln := len(cs); ln != sha256.Size {
+			checksumWriter: func(binChecksum []byte) {
+				if ln := len(binChecksum); ln != sha256.Size {
 					panic(fmt.Sprintf("wrong checksum length: expected %d, has %d", sha256.Size, ln))
 				}
 
 				csSHA := [sha256.Size]byte{}
-				copy(csSHA[:], cs)
+				copy(csSHA[:], binChecksum)
 
-				checksum := checksum.New()
-				checksum.SetSHA256(csSHA)
+				var cs checksum.Checksum
+				cs.SetSHA256(csSHA)
 
-				obj.SetPayloadChecksum(checksum)
+				obj.SetPayloadChecksum(cs)
 			},
 		},
 		{
 			hasher: tz.New(),
-			checksumWriter: func(cs []byte) {
-				if ln := len(cs); ln != tz.Size {
+			checksumWriter: func(binChecksum []byte) {
+				if ln := len(binChecksum); ln != tz.Size {
 					panic(fmt.Sprintf("wrong checksum length: expected %d, has %d", tz.Size, ln))
 				}
 
 				csTZ := [tz.Size]byte{}
-				copy(csTZ[:], cs)
+				copy(csTZ[:], binChecksum)
 
-				checksum := checksum.New()
-				checksum.SetTillichZemor(csTZ)
+				var cs checksum.Checksum
+				cs.SetTillichZemor(csTZ)
 
-				obj.SetPayloadHomomorphicHash(checksum)
+				obj.SetPayloadHomomorphicHash(cs)
 			},
 		},
 	}