[#851] ape: Initialize and use policy contract interface

* Replace inmemory policy contract mock by initialized
  policy contract interface.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

cmd/frostfs-cli/modules/control/add_rule.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"crypto/sha256"
 	"encoding/json"
-	"fmt"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/rpc/client"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
@@ -14,7 +13,6 @@ import (
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/control"
 	cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
 	apechain "git.frostfs.info/TrueCloudLab/policy-engine/pkg/chain"
-	nativeschema "git.frostfs.info/TrueCloudLab/policy-engine/schema/native"
 	"github.com/spf13/cobra"
 )
 
@@ -62,13 +60,11 @@ func addRule(cmd *cobra.Command, _ []string) {
 	cmd.Println("Container ID: " + cidStr)
 	cmd.Println("Parsed chain:\n" + prettyJSONFormat(cmd, serializedChain))
 
-	name := fmt.Sprintf(nativeschema.ResourceFormatRootContainerObjects, cidStr)
-
 	req := &control.AddChainLocalOverrideRequest{
 		Body: &control.AddChainLocalOverrideRequest_Body{
 			Target: &control.ChainTarget{
 				Type: control.ChainTarget_CONTAINER,
-				Name: name,
+				Name: cidStr,
 			},
 			Chain: serializedChain,
 		},

cmd/frostfs-cli/modules/control/get_rule.go

@@ -2,7 +2,6 @@ package control
 
 import (
 	"crypto/sha256"
-	"fmt"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/rpc/client"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
@@ -11,7 +10,6 @@ import (
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/control"
 	cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
 	apechain "git.frostfs.info/TrueCloudLab/policy-engine/pkg/chain"
-	nativeschema "git.frostfs.info/TrueCloudLab/policy-engine/schema/native"
 	"github.com/spf13/cobra"
 )
 
@@ -34,12 +32,10 @@ func getRule(cmd *cobra.Command, _ []string) {
 
 	chainID, _ := cmd.Flags().GetString(chainIDFlag)
 
-	name := fmt.Sprintf(nativeschema.ResourceFormatRootContainerObjects, cidStr)
-
 	req := &control.GetChainLocalOverrideRequest{
 		Body: &control.GetChainLocalOverrideRequest_Body{
 			Target: &control.ChainTarget{
-				Name: name,
+				Name: cidStr,
 				Type: control.ChainTarget_CONTAINER,
 			},
 			ChainId: chainID,

cmd/frostfs-cli/modules/control/list_rules.go

@@ -2,7 +2,6 @@ package control
 
 import (
 	"crypto/sha256"
-	"fmt"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/rpc/client"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
@@ -11,7 +10,6 @@ import (
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/control"
 	cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
 	apechain "git.frostfs.info/TrueCloudLab/policy-engine/pkg/chain"
-	nativeschema "git.frostfs.info/TrueCloudLab/policy-engine/schema/native"
 	"github.com/spf13/cobra"
 )
 
@@ -32,12 +30,10 @@ func listRules(cmd *cobra.Command, _ []string) {
 	rawCID := make([]byte, sha256.Size)
 	cnr.Encode(rawCID)
 
-	name := fmt.Sprintf(nativeschema.ResourceFormatRootContainerObjects, cidStr)
-
 	req := &control.ListChainLocalOverridesRequest{
 		Body: &control.ListChainLocalOverridesRequest_Body{
 			Target: &control.ChainTarget{
-				Name: name,
+				Name: cidStr,
 				Type: control.ChainTarget_CONTAINER,
 			},
 		},

cmd/frostfs-cli/modules/control/remove_rule.go

@@ -2,7 +2,6 @@ package control
 
 import (
 	"crypto/sha256"
-	"fmt"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/rpc/client"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
@@ -10,7 +9,6 @@ import (
 	commonCmd "git.frostfs.info/TrueCloudLab/frostfs-node/cmd/internal/common"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/control"
 	cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
-	nativeschema "git.frostfs.info/TrueCloudLab/policy-engine/schema/native"
 	"github.com/spf13/cobra"
 )
 
@@ -37,12 +35,10 @@ func removeRule(cmd *cobra.Command, _ []string) {
 
 	chainID, _ := cmd.Flags().GetString(chainIDFlag)
 
-	name := fmt.Sprintf(nativeschema.ResourceFormatRootContainerObjects, cidStr)
-
 	req := &control.RemoveChainLocalOverrideRequest{
 		Body: &control.RemoveChainLocalOverrideRequest_Body{
 			Target: &control.ChainTarget{
-				Name: name,
+				Name: cidStr,
 				Type: control.ChainTarget_CONTAINER,
 			},
 			ChainId: chainID,

cmd/frostfs-node/config.go

@@ -69,7 +69,7 @@ import (
 	objectSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object"
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/user"
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/version"
-	"git.frostfs.info/TrueCloudLab/policy-engine/pkg/engine/inmemory"
+	policy_client "git.frostfs.info/TrueCloudLab/policy-engine/pkg/morph/policy"
 	"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
 	neogoutil "github.com/nspcc-dev/neo-go/pkg/util"
 	"github.com/panjf2000/ants/v2"
@@ -542,6 +542,8 @@ type cfgLocalStorage struct {
 }
 
 type cfgAccessPolicyEngine struct {
+	policyContractHash neogoutil.Uint160
+
 	accessPolicyEngine *accessPolicyEngine
 }
 
@@ -987,7 +989,9 @@ func initAccessPolicyEngine(_ context.Context, c *cfg) {
 		)
 	}
 
-	morphRuleStorage := inmemory.NewInmemoryMorphRuleChainStorage()
+	morphRuleStorage := policy_client.NewContractStorage(
+		c.cfgMorph.client.GetActor(),
+		c.cfgObject.cfgAccessPolicyEngine.policyContractHash)
 
 	ape := newAccessPolicyEngine(morphRuleStorage, localOverrideDB)
 	c.cfgObject.cfgAccessPolicyEngine.accessPolicyEngine = ape

cmd/frostfs-node/main.go

@@ -98,14 +98,15 @@ func initApp(ctx context.Context, c *cfg) {
 		fatalOnErr(c.cfgObject.cfgLocalStorage.localStorage.Init(ctx))
 	})
 
+	initAndLog(c, "gRPC", initGRPC)
+	initAndLog(c, "netmap", func(c *cfg) { initNetmapService(ctx, c) })
+
 	initAccessPolicyEngine(ctx, c)
 	initAndLog(c, "access policy engine", func(c *cfg) {
 		fatalOnErr(c.cfgObject.cfgAccessPolicyEngine.accessPolicyEngine.LocalOverrideDatabaseCore().Open(ctx))
 		fatalOnErr(c.cfgObject.cfgAccessPolicyEngine.accessPolicyEngine.LocalOverrideDatabaseCore().Init())
 	})
 
-	initAndLog(c, "gRPC", initGRPC)
-	initAndLog(c, "netmap", func(c *cfg) { initNetmapService(ctx, c) })
 	initAndLog(c, "accounting", func(c *cfg) { initAccountingService(ctx, c) })
 	initAndLog(c, "container", func(c *cfg) { initContainerService(ctx, c) })
 	initAndLog(c, "session", initSessionService)

cmd/frostfs-node/morph.go

@@ -289,6 +289,7 @@ func lookupScriptHashesInNNS(c *cfg) {
 			{&c.cfgAccounting.scriptHash, client.NNSBalanceContractName},
 			{&c.cfgContainer.scriptHash, client.NNSContainerContractName},
 			{&c.cfgMorph.proxyScriptHash, client.NNSProxyContractName},
+			{&c.cfgObject.cfgAccessPolicyEngine.policyContractHash, client.NNSPolicyContractName},
 		}
 	)
 

go.mod

@@ -2,6 +2,8 @@ module git.frostfs.info/TrueCloudLab/frostfs-node
 
 go 1.20
 
+replace git.frostfs.info/TrueCloudLab/policy-engine v0.0.0-20231211080303-8c673ee4f4af => git.frostfs.info/aarifullin/policy-engine v0.0.0-20231212185618-def903261503
+
 require (
 	git.frostfs.info/TrueCloudLab/frostfs-api-go/v2 v2.16.1-0.20231031104748-498877e378fd
 	git.frostfs.info/TrueCloudLab/frostfs-contract v0.18.1-0.20231129062201-a1b61d394958

go.sum

@@ -11,12 +11,12 @@ git.frostfs.info/TrueCloudLab/frostfs-sdk-go v0.0.0-20231122162120-56debcfa569e
 git.frostfs.info/TrueCloudLab/frostfs-sdk-go v0.0.0-20231122162120-56debcfa569e/go.mod h1:t1akKcUH7iBrFHX8rSXScYMP17k2kYQXMbZooiL5Juw=
 git.frostfs.info/TrueCloudLab/hrw v1.2.1 h1:ccBRK21rFvY5R1WotI6LNoPlizk7qSvdfD8lNIRudVc=
 git.frostfs.info/TrueCloudLab/hrw v1.2.1/go.mod h1:C1Ygde2n843yTZEQ0FP69jYiuaYV0kriLvP4zm8JuvM=
-git.frostfs.info/TrueCloudLab/policy-engine v0.0.0-20231211080303-8c673ee4f4af h1:QSgejckGChrry5waJqf2votsOY0J7Sfh8tPqos0rCXA=
-git.frostfs.info/TrueCloudLab/policy-engine v0.0.0-20231211080303-8c673ee4f4af/go.mod h1:iJMX6qk9aIHIu3WVSd4puF5CHsNk5eOi++MaJJfNbXM=
 git.frostfs.info/TrueCloudLab/rfc6979 v0.4.0 h1:M2KR3iBj7WpY3hP10IevfIB9MURr4O9mwVfJ+SjT3HA=
 git.frostfs.info/TrueCloudLab/rfc6979 v0.4.0/go.mod h1:okpbKfVYf/BpejtfFTfhZqFP+sZ8rsHrP8Rr/jYPNRc=
 git.frostfs.info/TrueCloudLab/tzhash v1.8.0 h1:UFMnUIk0Zh17m8rjGHJMqku2hCgaXDqjqZzS4gsb4UA=
 git.frostfs.info/TrueCloudLab/tzhash v1.8.0/go.mod h1:dhY+oy274hV8wGvGL4MwwMpdL3GYvaX1a8GQZQHvlF8=
+git.frostfs.info/aarifullin/policy-engine v0.0.0-20231212185618-def903261503 h1:2Xaz7zC3o2dKYL58DPL+1CZxUYoWiAg0DGrbh7DLO9Q=
+git.frostfs.info/aarifullin/policy-engine v0.0.0-20231212185618-def903261503/go.mod h1:v43imcuSmDwSNrePe4UTQh8jaE8FmsiKN3FcaEzmRzc=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
 github.com/antlr4-go/antlr/v4 v4.13.0 h1:lxCg3LAv+EUK6t1i0y1V6/SLeUi0eKEKdhQAlS8TVTI=

pkg/morph/client/client.go

@@ -539,3 +539,7 @@ func (c *Client) setActor(act *actor.Actor) {
 	c.gasToken = nep17.New(act, gas.Hash)
 	c.rolemgmt = rolemgmt.New(act)
 }
+
+func (c *Client) GetActor() *actor.Actor {
+	return c.rpcActor
+}

pkg/morph/client/nns.go

@@ -33,6 +33,8 @@ const (
 	NNSProxyContractName = "proxy.frostfs"
 	// NNSGroupKeyName is a name for the FrostFS group key record in NNS.
 	NNSGroupKeyName = "group.frostfs"
+	// NNSPolicyContractName is a name of the policy contract in NNS.
+	NNSPolicyContractName = "policy.frostfs"
 )
 
 var (

pkg/services/object/acl/ape.go

@@ -26,7 +26,7 @@ func (c *apeCheckerImpl) CheckIfRequestPermitted(reqInfo v2.RequestInfo) error {
 	request := new(Request)
 	request.FromRequestInfo(reqInfo)
 
-	cnrTarget := getResource(reqInfo).Name()
+	cnrTarget := reqInfo.ContainerID().EncodeToString()
 
 	status, ruleFound, err := c.chainRouter.IsAllowed(apechain.Ingress, policyengine.NewRequestTargetWithContainer(cnrTarget), request)
 	if err != nil {