forked from TrueCloudLab/frostfs-node
1462824ab8
a1696a8 introduced some logic which in some situations prevented big objects
to be persisted in FSTree. In this commit a refactoring is done with the
goal of simplifying the code and also checking #866 issue.
1. Split a monstrous function into multiple simple ones: memory objects
can only be small and for writing through the cache we can do a dispatch
in `Put` itself.
2. Determine objects to be put in database before the actual update
as setting up a transaction has non-zero overhead.
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
52 lines
1,014 B
Go
52 lines
1,014 B
Go
package writecache
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"github.com/nspcc-dev/neofs-node/pkg/core/object"
|
|
storagelog "github.com/nspcc-dev/neofs-node/pkg/local_object_storage/internal/log"
|
|
)
|
|
|
|
// ErrBigObject is returned when object is too big to be placed in cache.
|
|
var ErrBigObject = errors.New("too big object")
|
|
|
|
// Put puts object to write-cache.
|
|
func (c *cache) Put(o *object.Object) error {
|
|
sz := uint64(o.ToV2().StableSize())
|
|
if sz > c.maxObjectSize {
|
|
return ErrBigObject
|
|
}
|
|
|
|
data, err := o.Marshal(nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
oi := objectInfo{
|
|
addr: o.Address().String(),
|
|
obj: o,
|
|
data: data,
|
|
}
|
|
|
|
c.mtx.Lock()
|
|
|
|
if sz <= c.smallObjectSize && c.curMemSize+sz <= c.maxMemSize {
|
|
c.curMemSize += sz
|
|
c.mem = append(c.mem, oi)
|
|
|
|
c.mtx.Unlock()
|
|
|
|
storagelog.Write(c.log, storagelog.AddressField(oi.addr), storagelog.OpField("in-mem PUT"))
|
|
|
|
return nil
|
|
}
|
|
|
|
c.mtx.Unlock()
|
|
|
|
if sz <= c.smallObjectSize {
|
|
c.persistSmallObjects([]objectInfo{oi})
|
|
} else {
|
|
c.persistBigObject(oi)
|
|
}
|
|
return nil
|
|
}
|