aarifullin/frostfs-sdk-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-sdk-go
Code Pull requests Activity

[#211] object: Fix setIDWithSignature

Browse source 
* Calculate and set checksum before ID is calculated.
* Add header verification for parts in unit-test.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
This commit is contained in:
Airat Arifullin 2024-03-28 18:53:34 +03:00
parent 425d48f68b
commit ec0cb2169f
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
object/erasurecode/split.go
View file

@ -44,12 +44,12 @@ func (c *Constructor) Split(obj *objectSDK.Object, key *ecdsa.PrivateKey) ([]*ob
} }
func setIDWithSignature(obj *objectSDK.Object, key *ecdsa.PrivateKey) error { func setIDWithSignature(obj *objectSDK.Object, key *ecdsa.PrivateKey) error {
objectSDK.CalculateAndSetPayloadChecksum(obj)
if err := objectSDK.CalculateAndSetID(obj); err != nil { if err := objectSDK.CalculateAndSetID(obj); err != nil {
return err return err
} }
objectSDK.CalculateAndSetPayloadChecksum(obj)
if key == nil { if key == nil {
return nil return nil
} }

9
object/erasurecode/split_test.go
View file

@ -3,6 +3,7 @@ package erasurecode_test
import ( import (
"testing" "testing"
objectSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object"
"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/erasurecode" "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/erasurecode"
"github.com/nspcc-dev/neo-go/pkg/crypto/keys" "github.com/nspcc-dev/neo-go/pkg/crypto/keys"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
@ -23,6 +24,10 @@ func TestSplitMaxShardCount(t *testing.T) {
parts, err := c.Split(original, &pk.PrivateKey) parts, err := c.Split(original, &pk.PrivateKey)
require.NoError(t, err) require.NoError(t, err)
require.Len(t, parts, erasurecode.MaxShardCount) require.Len(t, parts, erasurecode.MaxShardCount)
for _, part := range parts {
require.NoError(t, objectSDK.CheckHeaderVerificationFields(part))
}
}) })
t.Run("data + parity", func(t *testing.T) { t.Run("data + parity", func(t *testing.T) {
c, err := erasurecode.NewConstructor(1, erasurecode.MaxShardCount-1) c, err := erasurecode.NewConstructor(1, erasurecode.MaxShardCount-1)
@ -31,6 +36,10 @@ func TestSplitMaxShardCount(t *testing.T) {
parts, err := c.Split(original, &pk.PrivateKey) parts, err := c.Split(original, &pk.PrivateKey)
require.NoError(t, err) require.NoError(t, err)
require.Len(t, parts, erasurecode.MaxShardCount) require.Len(t, parts, erasurecode.MaxShardCount)
for _, part := range parts {
require.NoError(t, objectSDK.CheckHeaderVerificationFields(part))
}
}) })
} }