aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

native: clear LastGasPerVote when voting for NULL

Browse source 
Port neo-project/neo#3173.

Close #3345

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
This commit is contained in:
Ekaterina Pavlova 2024-03-14 17:23:36 +03:00
parent 9c83beffbb
commit 0e6fbadfd5
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/core/native/native_neo.go
View file

@ -930,6 +930,9 @@ func (n *NEO) VoteInternal(ic *interop.Context, h util.Uint160, pub *keys.Public
if err := n.ModifyAccountVotes(acc, ic.DAO, &acc.Balance, true); err != nil { if err := n.ModifyAccountVotes(acc, ic.DAO, &acc.Balance, true); err != nil {
return err return err
} }
if pub == nil {
acc.LastGasPerVote = *big.NewInt(0)
}
ic.DAO.PutStorageItem(n.ID, key, acc.Bytes(ic.DAO.GetItemCtx())) ic.DAO.PutStorageItem(n.ID, key, acc.Bytes(ic.DAO.GetItemCtx()))
ic.AddNotification(n.Hash, "Vote", stackitem.NewArray([]stackitem.Item{ ic.AddNotification(n.Hash, "Vote", stackitem.NewArray([]stackitem.Item{

29
pkg/core/native/native_test/neo_test.go
View file

@ -271,6 +271,35 @@ func TestNEO_Vote(t *testing.T) {
require.NotEqual(t, candidates[0], pubs[i]) require.NotEqual(t, candidates[0], pubs[i])
require.NotEqual(t, candidates[len(candidates)-1], pubs[i]) require.NotEqual(t, candidates[len(candidates)-1], pubs[i])
} }
// LastGasPerVote should be 0 after unvoting
getAccountState := func(t *testing.T, account util.Uint160) *state.NEOBalance {
stack, err := neoCommitteeInvoker.TestInvoke(t, "getAccountState", account)
require.NoError(t, err)
res := stack.Pop().Item()
// (s *NEOBalance) FromStackItem is able to handle both 3 and 4 subitems.
// The forth optional subitem is LastGasPerVote.
require.Equal(t, 4, len(res.Value().([]stackitem.Item)))
as := new(state.NEOBalance)
err = as.FromStackItem(res)
require.NoError(t, err)
return as
}
registerTx = neoValidatorsInvoker.WithSigners(candidates[0]).PrepareInvoke(t, "registerCandidate", candidates[0].(neotest.SingleSigner).Account().PublicKey().Bytes())
voteTx = neoValidatorsInvoker.WithSigners(voters[0]).PrepareInvoke(t, "vote", voters[0].(neotest.SingleSigner).Account().PrivateKey().GetScriptHash(), candidates[0].(neotest.SingleSigner).Account().PublicKey().Bytes())
neoValidatorsInvoker.AddNewBlock(t, registerTx, voteTx)
e.CheckHalt(t, registerTx.Hash(), stackitem.Make(true))
e.CheckHalt(t, voteTx.Hash(), stackitem.Make(true))
stateBeforeUnvote := getAccountState(t, voters[0].ScriptHash())
require.NotEqual(t, uint64(0), stateBeforeUnvote.LastGasPerVote.Uint64())
// Unvote
unvoteTx := neoValidatorsInvoker.WithSigners(voters[0]).PrepareInvoke(t, "vote", voters[0].(neotest.SingleSigner).Account().PrivateKey().GetScriptHash(), nil)
neoValidatorsInvoker.AddNewBlock(t, unvoteTx)
e.CheckHalt(t, unvoteTx.Hash(), stackitem.Make(true))
advanceChain(t)
stateAfterUnvote := getAccountState(t, voters[0].ScriptHash())
require.Equal(t, uint64(0), stateAfterUnvote.LastGasPerVote.Uint64())
} }
// TestNEO_RecursiveDistribution is a test for https://github.com/nspcc-dev/neo-go/pull/2181. // TestNEO_RecursiveDistribution is a test for https://github.com/nspcc-dev/neo-go/pull/2181.