From eb8122837eb522bacb0d94aed839b2a8fc3cb258 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Wed, 19 Aug 2020 13:19:09 +0300 Subject: [PATCH] core: fix failing TestGetTransaction 3677cc0e2 ruined it: TestGetTransaction: blockchain_test.go:413: Error Trace: blockchain_test.go:413 Error: Not equal: expected: 467 actual : 399 Test: TestGetTransaction --- pkg/core/blockchain_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/core/blockchain_test.go b/pkg/core/blockchain_test.go index 4a9090828..1b9ba1af4 100644 --- a/pkg/core/blockchain_test.go +++ b/pkg/core/blockchain_test.go @@ -384,24 +384,23 @@ func TestHasBlock(t *testing.T) { func TestGetTransaction(t *testing.T) { bc := newTestChain(t) tx1 := transaction.New(netmode.UnitTestNet, []byte{byte(opcode.PUSH1)}, 0) + tx1.ValidUntilBlock = 16 tx1.Signers = []transaction.Signer{{ Account: testchain.MultisigScriptHash(), Scopes: transaction.CalledByEntry, }} tx2 := transaction.New(netmode.UnitTestNet, []byte{byte(opcode.PUSH2)}, 0) + tx2.ValidUntilBlock = 16 tx2.Signers = []transaction.Signer{{ Account: testchain.MultisigScriptHash(), Scopes: transaction.CalledByEntry, }} require.NoError(t, signTx(bc, tx1, tx2)) b1 := bc.newBlock(tx1) - // Turn verification off, because these blocks are really from some other chain - // and can't be verified, but we don't care about that in this test. - bc.config.VerifyBlocks = false - bc.config.VerifyTransactions = false assert.Nil(t, bc.AddBlock(b1)) block := bc.newBlock(tx2) + txSize := io.GetVarSize(tx2) assert.Nil(t, bc.AddBlock(block)) // Test unpersisted and persisted access @@ -410,7 +409,7 @@ func TestGetTransaction(t *testing.T) { require.Nil(t, err) assert.Equal(t, block.Index, height) assert.Equal(t, block.Transactions[0], tx) - assert.Equal(t, 467, io.GetVarSize(tx)) + assert.Equal(t, txSize, io.GetVarSize(tx)) assert.Equal(t, 1, io.GetVarSize(tx.Attributes)) assert.Equal(t, 1, io.GetVarSize(tx.Scripts)) assert.NoError(t, bc.persist())