aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

vm: fail if NIP has not enough arguments

Browse source
This commit is contained in:
Evgenii Stratonikov 2019-09-12 11:09:23 +03:00
parent 6e4014547d
commit 1881adabb9
2 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/vm/vm.go
View file

@ -398,9 +398,10 @@ func (v *VM) execute(ctx *Context, op Instruction) {
v.estack.PushVal(v.estack.Len()) v.estack.PushVal(v.estack.Len())
case NIP: case NIP:
elem := v.estack.Pop() elem := v.estack.RemoveAt(1)
_ = v.estack.Pop() if elem == nil {
v.estack.Push(elem) panic("no second element found")
}
case OVER: case OVER:
b := v.estack.Pop() b := v.estack.Pop()

19
pkg/vm/vm_test.go
View file

@ -803,6 +803,25 @@ func TestOVERgood(t *testing.T) {
assert.Equal(t, 3, vm.estack.Len()) assert.Equal(t, 3, vm.estack.Len())
} }
func TestNIPBadNoItem(t *testing.T) {
prog := makeProgram(NIP)
vm := load(prog)
vm.estack.PushVal(1)
vm.Run()
assert.Equal(t, true, vm.state.HasFlag(faultState))
}
func TestNIPGood(t *testing.T) {
prog := makeProgram(NIP)
vm := load(prog)
vm.estack.PushVal(1)
vm.estack.PushVal(2)
vm.Run()
assert.Equal(t, false, vm.state.HasFlag(faultState))
assert.Equal(t, 1, vm.estack.Len())
assert.Equal(t, makeStackItem(2), vm.estack.Pop().value)
}
func TestDROPBadNoItem(t *testing.T) { func TestDROPBadNoItem(t *testing.T) {
prog := makeProgram(DROP) prog := makeProgram(DROP)
vm := load(prog) vm := load(prog)