aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

Merge pull request #1551 from nspcc-dev/core/adjust_runtime_notify

Browse source 
core: adjust System.Runtime.Notify interop
This commit is contained in:
Roman Khimov 2020-11-18 21:40:54 +03:00 committed by GitHub
commit 4640ba2758
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/core/interop_system.go
View file

@ -266,12 +266,13 @@ func runtimeNotify(ic *interop.Context) error {
args := elem.Array()
// But it has to be serializable, otherwise we either have some broken
// (recursive) structure inside or an interop item that can't be used
// outside of the interop subsystem anyway. I'd probably fail transactions
// that emit such broken notifications, but that might break compatibility
// with testnet/mainnet, so we're replacing these with error messages.
_, err := stackitem.SerializeItem(elem.Item())
// outside of the interop subsystem anyway.
bytes, err := stackitem.SerializeItem(elem.Item())
if err != nil {
args = []stackitem.Item{stackitem.NewByteArray([]byte(fmt.Sprintf("bad notification: %v", err)))}
return fmt.Errorf("bad notification: %w", err)
}
if len(bytes) > MaxNotificationSize {
return fmt.Errorf("notification size shouldn't exceed %d", MaxNotificationSize)
}
ne := state.NotificationEvent{
ScriptHash: ic.VM.GetCurrentScriptHash(),