From 4a732d97ac16b276ed85fe9768ee030b7dfcf4d5 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Thu, 26 Sep 2019 18:35:36 +0300 Subject: [PATCH] storage: add comments about errors from MemoryStore It never returns errors for some operations and this knowledge can be used by other code. --- pkg/core/storage/memory_store.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/core/storage/memory_store.go b/pkg/core/storage/memory_store.go index 0f2a92428..59d74a02a 100644 --- a/pkg/core/storage/memory_store.go +++ b/pkg/core/storage/memory_store.go @@ -47,7 +47,7 @@ func (s *MemoryStore) Get(key []byte) ([]byte, error) { return nil, ErrKeyNotFound } -// Put implements the Store interface. +// Put implements the Store interface. Never returns an error. func (s *MemoryStore) Put(key, value []byte) error { s.Lock() s.mem[makeKey(key)] = value @@ -55,7 +55,7 @@ func (s *MemoryStore) Put(key, value []byte) error { return nil } -// PutBatch implements the Store interface. +// PutBatch implements the Store interface. Never returns an error. func (s *MemoryStore) PutBatch(batch Batch) error { b := batch.(*MemoryBatch) for k, v := range b.m { @@ -105,7 +105,8 @@ func (s *MemoryStore) Persist(ps Store) (int, error) { return keys, err } -// Close implements Store interface and clears up memory. +// Close implements Store interface and clears up memory. Never returns an +// error. func (s *MemoryStore) Close() error { s.Lock() s.mem = nil