From 4e077838a2a0ff96a5da09bd3353976f8210f055 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Tue, 20 Aug 2019 17:53:52 +0300 Subject: [PATCH] CONTRIBUTING: adapt to new reality a bit See #298 for example. --- CONTRIBUTING.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a1cf81c94..85946ec5c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,6 +8,10 @@ follow the guidelines: 1. Open an issue first, to discuss a new feature or enhancement. 1. Write tests, and make sure the test suite passes locally and on CI. 1. Open a pull request, and reference the relevant issue(s). -1. After receiving feedback, squash your commits and add a great commit message. -1. Run `make push-tag` after merging your pull request. -1. **Have fun!** \ No newline at end of file +1. Make sure your commits are logically separated and have good comments + explaining the details of your change. Add a package/file prefix to your + commit if that's applicable (like 'vm: fix ADD miscalculation on full + moon'). +1. After receiving feedback, amend your commits or add new ones as + appropriate. +1. **Have fun!**