aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

vm: restrict max size in SETITEM

Browse source
This commit is contained in:
Evgenii Stratonikov 2019-10-17 11:18:15 +03:00
parent 6f1f9e56bb
commit 6d7016c3b9
2 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/vm/vm.go
View file

@ -871,6 +871,9 @@ func (v *VM) execute(ctx *Context, op Instruction, parameter []byte) {
} }
arr[index] = item arr[index] = item
case *MapItem: case *MapItem:
if !t.Has(key.value) && len(t.value) >= MaxArraySize {
panic("too big map")
}
t.Add(key.value, item) t.Add(key.value, item)
default: default:

32
pkg/vm/vm_test.go
View file

@ -734,6 +734,38 @@ func TestSETITEMMap(t *testing.T) {
assert.Equal(t, makeStackItem([]byte{0, 1}), vm.estack.Pop().value) assert.Equal(t, makeStackItem([]byte{0, 1}), vm.estack.Pop().value)
} }
func TestSETITEMBigMapBad(t *testing.T) {
prog := makeProgram(SETITEM)
vm := load(prog)
m := NewMapItem()
for i := 0; i < MaxArraySize; i++ {
m.Add(makeStackItem(i), makeStackItem(i))
}
vm.estack.Push(&Element{value: m})
vm.estack.PushVal(MaxArraySize)
vm.estack.PushVal(0)
vm.Run()
assert.Equal(t, true, vm.HasFailed())
}
func TestSETITEMBigMapGood(t *testing.T) {
prog := makeProgram(SETITEM)
vm := load(prog)
m := NewMapItem()
for i := 0; i < MaxArraySize; i++ {
m.Add(makeStackItem(i), makeStackItem(i))
}
vm.estack.Push(&Element{value: m})
vm.estack.PushVal(0)
vm.estack.PushVal(0)
vm.Run()
assert.Equal(t, false, vm.HasFailed())
}
func TestSIZENoArgument(t *testing.T) { func TestSIZENoArgument(t *testing.T) {
prog := makeProgram(SIZE) prog := makeProgram(SIZE)
vm := load(prog) vm := load(prog)