aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

util: add error check to Read/WriteVarUint

Browse source 
Fixes possibility of bogus reads/writes. Suggested by @im-kulikov.
This commit is contained in:
Roman Khimov 2019-08-29 13:24:03 +03:00
parent 15311f202b
commit 7b46f9bb86
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/util/binaryReader.go
View file

@ -33,6 +33,10 @@ func (r *BinReader) ReadBE(v interface{}) {
// ReadVarUint reads a variable-length-encoded integer from the
// underlying reader
func (r *BinReader) ReadVarUint() uint64 {
if r.Err != nil {
return 0
}
var b uint8
r.Err = binary.Read(r.R, binary.LittleEndian, &b)

4
pkg/util/binaryWriter.go
View file

@ -32,6 +32,10 @@ func (w *BinWriter) WriteBE(v interface{}) {
// WriteVarUint writes a uint64 into the underlying writer using variable-length encoding
func (w *BinWriter) WriteVarUint(val uint64) {
if w.Err != nil {
return
}
if val < 0 {
w.Err = errors.New("value out of range")
return