aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

core: add max nodes count restriction to designate contract

Browse source
This commit is contained in:
Anna Shaleva 2020-10-21 12:50:26 +03:00
parent 5bba9c158a
commit 7c232e2ddc
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/core/native/designate.go
View file

@ -30,6 +30,9 @@ type Designate struct {
const ( const (
designateContractID = -5 designateContractID = -5
designateName = "Designation" designateName = "Designation"
// maxNodeCount is the maximum number of nodes to set the role for.
maxNodeCount = 32
) )
// Role represents type of participant. // Role represents type of participant.
@ -45,6 +48,7 @@ const (
var ( var (
ErrInvalidRole = errors.New("invalid role") ErrInvalidRole = errors.New("invalid role")
ErrEmptyNodeList = errors.New("node list is empty") ErrEmptyNodeList = errors.New("node list is empty")
ErrLargeNodeList = errors.New("node list is too large")
) )
func isValidRole(r Role) bool { func isValidRole(r Role) bool {
@ -162,9 +166,13 @@ func (s *Designate) designateAsRole(ic *interop.Context, args []stackitem.Item)
// DesignateAsRole sets nodes for role r. // DesignateAsRole sets nodes for role r.
func (s *Designate) DesignateAsRole(ic *interop.Context, r Role, pubs keys.PublicKeys) error { func (s *Designate) DesignateAsRole(ic *interop.Context, r Role, pubs keys.PublicKeys) error {
if len(pubs) == 0 { length := len(pubs)
if length == 0 {
return ErrEmptyNodeList return ErrEmptyNodeList
} }
if length > maxNodeCount {
return ErrLargeNodeList
}
if !isValidRole(r) { if !isValidRole(r) {
return ErrInvalidRole return ErrInvalidRole
} }

3
pkg/core/native_designate_test.go
View file

@ -92,6 +92,9 @@ func TestDesignate_DesignateAsRole(t *testing.T) {
err = des.DesignateAsRole(ic, native.RoleOracle, keys.PublicKeys{}) err = des.DesignateAsRole(ic, native.RoleOracle, keys.PublicKeys{})
require.True(t, errors.Is(err, native.ErrEmptyNodeList), "got: %v", err) require.True(t, errors.Is(err, native.ErrEmptyNodeList), "got: %v", err)
err = des.DesignateAsRole(ic, native.RoleOracle, make(keys.PublicKeys, 32+1))
require.True(t, errors.Is(err, native.ErrLargeNodeList), "got: %v", err)
priv, err := keys.NewPrivateKey() priv, err := keys.NewPrivateKey()
require.NoError(t, err) require.NoError(t, err)
pub := priv.PublicKey() pub := priv.PublicKey()