Merge pull request #3077 from nspcc-dev/rel-0.101.4

Rel 0.101.4

CHANGELOG.md

@@ -2,6 +2,47 @@
 
 This document outlines major changes between releases.
 
+## 0.101.4 "Yarborough" (01 Aug 2023)
+
+Another one 3.5.0-compatible version that is aimed to fix T5 testnet state
+difference that has happened at block 2336911 which leads to inability to process
+new blocks since 2418703. The issue is fixed by allowing JSON numbers
+unmarshalling from scientific notation to Integer stackitem. Maximum parsing
+precision for such numbers is currently restricted by 53 bits. This is a
+temporary C#-compatible solution that is likely to change in the future versions
+when an appropriate C# node bug is fixed (neo-project/neo#2879).
+
+A set of minor bug fixes is included as well to flush some of the long-awaited
+changes that were blocked by the 0.102.0 release delay (caused by v3.6.0 C# node
+release delay). In particular, invalid headers returned by an RPC server for
+error responses, invalid format of incremental dumps created by CLI and deadlock
+on unhealthy RPC server shutdown. Long-awaited `--config-file` CLI option to
+start the node providing a single configuration file is added.
+
+T5 testnet chain requires a complete resynchronization for this version. Mainnet
+chain resynchronization is recommended, but not required.
+
+New features:
+ * `--config-file` CLI option allowing to start the node with a single configuration file (#3014)
+
+Improvements:
+ * blockchain Notary and Oracle services documentation improvement (#2972)
+ * BoltDB (`go.etcd.io/bbolt`) dependency upgrade that fixes a number of Windows-related issues (#3034)
+
+Bugs fixed:
+ * panic on node start with invalid configuration (#2968)
+ * deadlock on unhealthy RPC server shutdown (#2966)
+ * improper WSClient notification channels managing after disconnection (#2980)
+ * missing Prometheus metric initialisation on node start (#2992)
+ * invalid initialisation of native contracts cache (#2994)
+ * incorrect way of incremental DB dumps creation (#3047)
+ * Notary contract is allowed to be a sender of main Notary request transaction (#3065)
+ * discrepancy in signer's witness scope parsing on the RPC server side (#3060)
+ * Invoker calling API isn't allowed to accept nil parameter (#3067)
+ * contract RPC Client unwrapper helper can't handle missing contract case (#3072)
+ * JSON numbers can't be unmarshalled to stackitem from scientific notation (#3073)
+ * invalid content-type header returned by RPC server on error responses (#3075)
+
 ## 0.101.3 "Yuckiness" (08 Jul 2023)
 
 Yet another 3.5.0-compatible emergency version that removes scrupulous

go.sum

@@ -514,7 +514,6 @@ golang.org/x/tools v0.2.0/go.mod h1:y4OqIKeOV/fWJetJ8bXPU1sEVniLMIyDAZWeHdV+NTA=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
-golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
 golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 google.golang.org/api v0.4.0/go.mod h1:8k5glujaEP+g9n7WNsDg8QP6cUVNI86fCNMcbazEtwE=
 google.golang.org/api v0.7.0/go.mod h1:WtwebWUNSVBH/HAw79HIFXZNqEvBhG+Ra+ax0hx3E3M=
@@ -600,18 +599,15 @@ google.golang.org/protobuf v1.28.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqw
 gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
-gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 h1:YR8cESwS4TdDjEe65xsg0ogRM/Nc3DYOhEAlW+xobZo=
 gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/errgo.v2 v2.1.0/go.mod h1:hNsd1EY+bozCKY1Ytp96fpM3vjJbqLJn88ws8XvfDNI=
 gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMys=
-gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=
 gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw=
 gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.2.5/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
-gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
 gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

pkg/rpcclient/wsclient_test.go

@@ -37,6 +37,10 @@ func TestWSClientClose(t *testing.T) {
 	bCh := make(chan *block.Block)
 	_, err = wsc.ReceiveBlocks(nil, bCh)
 	require.NoError(t, err)
+	wsc.getNextRequestID = getTestRequestID
+	bCh := make(chan *block.Block)
+	_, err = wsc.ReceiveBlocks(nil, bCh)
+	require.NoError(t, err)
 	wsc.Close()
 	// Subscriber channel must be closed by server.
 	_, ok := <-bCh