aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

rpc: correctly handle RPC invocations with no arguments, fix #2219

Browse source 
In N3 no arguments passed should be treated as empty arguments array not as
missing array of arguments, because the array must be present even for
functions that accept no parameters.
This commit is contained in:
Roman Khimov 2021-10-16 21:09:29 +03:00
parent ab3df6cc52
commit b44f9eefb0
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/rpc/request/txBuilder.go
View file

@ -127,6 +127,9 @@ func CreateFunctionInvocationScript(contract util.Uint160, method string, params
emit.Opcodes(script.BinWriter, opcode.PACK)
}
}
if len(params) == 0 {
emit.Opcodes(script.BinWriter, opcode.NEWARRAY0)
}
emit.AppCallNoArgs(script.BinWriter, contract, method, callflag.All)
return script.Bytes(), nil

4
pkg/rpc/request/tx_builder_test.go
View file

@ -22,10 +22,10 @@ func TestInvocationScriptCreationGood(t *testing.T) {
script string
}{{
ps: Params{{Type: StringT, Value: "transfer"}},
script: "1f0c087472616e736665720c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
script: "c21f0c087472616e736665720c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
}, {
ps: Params{{Type: NumberT, Value: 42}},
script: "1f0c0234320c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
script: "c21f0c0234320c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
}, {
ps: Params{{Type: StringT, Value: "m"}, {Type: BooleanT, Value: true}},
script: "11db201f0c016d0c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",