aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

cli/wallet: avoid parsing address in signStoredTransaction

Browse source 
It's not needed, we already have the hash and getDecryptedAccount can't return
an account for a different one.
This commit is contained in:
Roman Khimov 2022-08-31 13:06:31 +03:00
parent 773bcc3a59
commit c316107c9f
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cli/wallet/multisig.go
View file

@ -8,7 +8,6 @@ import (
"github.com/nspcc-dev/neo-go/cli/options" "github.com/nspcc-dev/neo-go/cli/options"
"github.com/nspcc-dev/neo-go/cli/paramcontext" "github.com/nspcc-dev/neo-go/cli/paramcontext"
"github.com/nspcc-dev/neo-go/pkg/core/transaction" "github.com/nspcc-dev/neo-go/pkg/core/transaction"
"github.com/nspcc-dev/neo-go/pkg/encoding/address"
"github.com/urfave/cli" "github.com/urfave/cli"
) )
@ -29,7 +28,9 @@ func signStoredTransaction(ctx *cli.Context) error {
if !addrFlag.IsSet { if !addrFlag.IsSet {
return cli.NewExitError("address was not provided", 1) return cli.NewExitError("address was not provided", 1)
} }
acc, err := getDecryptedAccount(wall, addrFlag.Uint160(), pass)
var ch = addrFlag.Uint160()
acc, err := getDecryptedAccount(wall, ch, pass)
if err != nil { if err != nil {
return cli.NewExitError(err, 1) return cli.NewExitError(err, 1)
} }
@ -39,10 +40,6 @@ func signStoredTransaction(ctx *cli.Context) error {
return cli.NewExitError("verifiable item is not a transaction", 1) return cli.NewExitError("verifiable item is not a transaction", 1)
} }
ch, err := address.StringToUint160(acc.Address)
if err != nil {
return cli.NewExitError(fmt.Errorf("wallet contains invalid account: %s", acc.Address), 1)
}
signerFound := false signerFound := false
for i := range tx.Signers { for i := range tx.Signers {
if tx.Signers[i].Account == ch { if tx.Signers[i].Account == ch {