aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

rpcclient: correct Init requirement in documentation

Browse source
This commit is contained in:
Roman Khimov 2022-09-07 19:09:53 +03:00
parent ee55e95c28
commit c4ddf80742
2 changed files with 16 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/rpcclient/client.go
View file

@ -86,7 +86,8 @@ type calculateValidUntilBlockCache struct {
} }
// New returns a new Client ready to use. You should call Init method to // New returns a new Client ready to use. You should call Init method to
// initialize network magic the client is operating on. // initialize stateroot setting for the network the client is operating on if
// you plan using GetBlock*.
func New(ctx context.Context, endpoint string, opts Options) (*Client, error) { func New(ctx context.Context, endpoint string, opts Options) (*Client, error) {
cl := new(Client) cl := new(Client)
err := initClient(ctx, cl, endpoint, opts) err := initClient(ctx, cl, endpoint, opts)

24
pkg/rpcclient/rpc.go
View file

@ -81,14 +81,14 @@ func (c *Client) GetBlockCount() (uint32, error) {
return resp, nil return resp, nil
} }
// GetBlockByIndex returns a block by its height. You should initialize network magic // GetBlockByIndex returns a block by its height. In-header stateroot option
// with Init before calling GetBlockByIndex. // must be initialized with Init before calling this method.
func (c *Client) GetBlockByIndex(index uint32) (*block.Block, error) { func (c *Client) GetBlockByIndex(index uint32) (*block.Block, error) {
return c.getBlock(index) return c.getBlock(index)
} }
// GetBlockByHash returns a block by its hash. You should initialize network magic // GetBlockByHash returns a block by its hash. In-header stateroot option
// with Init before calling GetBlockByHash. // must be initialized with Init before calling this method.
func (c *Client) GetBlockByHash(hash util.Uint256) (*block.Block, error) { func (c *Client) GetBlockByHash(hash util.Uint256) (*block.Block, error) {
return c.getBlock(hash.StringLE()) return c.getBlock(hash.StringLE())
} }
@ -116,14 +116,16 @@ func (c *Client) getBlock(param interface{}) (*block.Block, error) {
} }
// GetBlockByIndexVerbose returns a block wrapper with additional metadata by // GetBlockByIndexVerbose returns a block wrapper with additional metadata by
// its height. You should initialize network magic with Init before calling GetBlockByIndexVerbose. // its height. In-header stateroot option must be initialized with Init before
// calling this method.
// NOTE: to get transaction.ID and transaction.Size, use t.Hash() and io.GetVarSize(t) respectively. // NOTE: to get transaction.ID and transaction.Size, use t.Hash() and io.GetVarSize(t) respectively.
func (c *Client) GetBlockByIndexVerbose(index uint32) (*result.Block, error) { func (c *Client) GetBlockByIndexVerbose(index uint32) (*result.Block, error) {
return c.getBlockVerbose(index) return c.getBlockVerbose(index)
} }
// GetBlockByHashVerbose returns a block wrapper with additional metadata by // GetBlockByHashVerbose returns a block wrapper with additional metadata by
// its hash. You should initialize network magic with Init before calling GetBlockByHashVerbose. // its hash. In-header stateroot option must be initialized with Init before
// calling this method.
func (c *Client) GetBlockByHashVerbose(hash util.Uint256) (*result.Block, error) { func (c *Client) GetBlockByHashVerbose(hash util.Uint256) (*result.Block, error) {
return c.getBlockVerbose(hash.StringLE()) return c.getBlockVerbose(hash.StringLE())
} }
@ -158,8 +160,8 @@ func (c *Client) GetBlockHash(index uint32) (util.Uint256, error) {
} }
// GetBlockHeader returns the corresponding block header information from a serialized hex string // GetBlockHeader returns the corresponding block header information from a serialized hex string
// according to the specified script hash. You should initialize network magic // according to the specified script hash. In-header stateroot option must be
// with Init before calling GetBlockHeader. // initialized with Init before calling this method.
func (c *Client) GetBlockHeader(hash util.Uint256) (*block.Header, error) { func (c *Client) GetBlockHeader(hash util.Uint256) (*block.Header, error) {
var ( var (
params = []interface{}{hash.StringLE()} params = []interface{}{hash.StringLE()}
@ -193,7 +195,8 @@ func (c *Client) GetBlockHeaderCount() (uint32, error) {
} }
// GetBlockHeaderVerbose returns the corresponding block header information from a Json format string // GetBlockHeaderVerbose returns the corresponding block header information from a Json format string
// according to the specified script hash. // according to the specified script hash. In-header stateroot option must be
// initialized with Init before calling this method.
func (c *Client) GetBlockHeaderVerbose(hash util.Uint256) (*result.Header, error) { func (c *Client) GetBlockHeaderVerbose(hash util.Uint256) (*result.Header, error) {
var ( var (
params = []interface{}{hash.StringLE(), 1} params = []interface{}{hash.StringLE(), 1}
@ -1095,7 +1098,8 @@ func (c *Client) AddNetworkFee(tx *transaction.Transaction, extraFee int64, accs
return nil return nil
} }
// GetNetwork returns the network magic of the RPC node the client connected to. // GetNetwork returns the network magic of the RPC node the client connected to. It
// requires Init to be done first, otherwise an error is returned.
func (c *Client) GetNetwork() (netmode.Magic, error) { func (c *Client) GetNetwork() (netmode.Magic, error) {
c.cacheLock.RLock() c.cacheLock.RLock()
defer c.cacheLock.RUnlock() defer c.cacheLock.RUnlock()