diff --git a/cli/query/query.go b/cli/query/query.go index d77850591..9ee5b560d 100644 --- a/cli/query/query.go +++ b/cli/query/query.go @@ -9,6 +9,7 @@ import ( "text/tabwriter" "github.com/nspcc-dev/neo-go/cli/options" + "github.com/nspcc-dev/neo-go/pkg/encoding/address" "github.com/nspcc-dev/neo-go/pkg/encoding/fixedn" "github.com/nspcc-dev/neo-go/pkg/rpc/response/result" "github.com/nspcc-dev/neo-go/pkg/util" @@ -26,11 +27,11 @@ func NewCommands() []cli.Command { }, options.RPC...) return []cli.Command{{ Name: "query", - Usage: "query", + Usage: "Query data from RPC node", Subcommands: []cli.Command{ { Name: "tx", - Usage: "query tx status", + Usage: "Query transaction status", Action: queryTx, Flags: queryTxFlags, }, @@ -86,12 +87,16 @@ func dumpApplicationLog(ctx *cli.Context, res *result.ApplicationLog, tx *result _, _ = tw.Write([]byte("ValidUntil:\t" + strconv.FormatUint(uint64(tx.ValidUntilBlock), 10) + "\n")) } else { _, _ = tw.Write([]byte("BlockHash:\t" + tx.Blockhash.StringLE() + "\n")) - _, _ = tw.Write([]byte(fmt.Sprintf("Success:\t%t\n", tx.VMState == vm.HaltState.String()))) + if len(res.Executions) != 1 { + _, _ = tw.Write([]byte("Success:\tunknown (no execution data)\n")) + } else { + _, _ = tw.Write([]byte(fmt.Sprintf("Success:\t%t\n", res.Executions[0].VMState == vm.HaltState))) + } } if verbose { for _, sig := range tx.Signers { _, _ = tw.Write([]byte(fmt.Sprintf("Signer:\t%s (%s)", - sig.Account.StringLE(), + address.Uint160ToString(sig.Account), sig.Scopes) + "\n")) } _, _ = tw.Write([]byte("SystemFee:\t" + fixedn.Fixed8(tx.SystemFee).String() + " GAS\n")) diff --git a/cli/query_test.go b/cli/query_test.go index d267b4903..0e6f8e9d2 100644 --- a/cli/query_test.go +++ b/cli/query_test.go @@ -11,6 +11,7 @@ import ( "github.com/nspcc-dev/neo-go/internal/random" "github.com/nspcc-dev/neo-go/pkg/core/transaction" + "github.com/nspcc-dev/neo-go/pkg/encoding/address" "github.com/nspcc-dev/neo-go/pkg/encoding/fixedn" "github.com/nspcc-dev/neo-go/pkg/smartcontract/trigger" "github.com/nspcc-dev/neo-go/pkg/util" @@ -118,7 +119,7 @@ func (e *executor) compareQueryTxVerbose(t *testing.T, tx *transaction.Transacti res, _ := e.Chain.GetAppExecResults(tx.Hash(), trigger.Application) e.checkNextLine(t, fmt.Sprintf(`Success:\s+%t`, res[0].Execution.VMState == vm.HaltState)) for _, s := range tx.Signers { - e.checkNextLine(t, fmt.Sprintf(`Signer:\s+%s\s*\(%s\)`, s.Account.StringLE(), s.Scopes.String())) + e.checkNextLine(t, fmt.Sprintf(`Signer:\s+%s\s*\(%s\)`, address.Uint160ToString(s.Account), s.Scopes.String())) } e.checkNextLine(t, `SystemFee:\s+`+fixedn.Fixed8(tx.SystemFee).String()+" GAS$") e.checkNextLine(t, `NetworkFee:\s+`+fixedn.Fixed8(tx.NetworkFee).String()+" GAS$")