From f96c217abab52e1ace275e83a2f8ab8aaad7e040 Mon Sep 17 00:00:00 2001
From: Evgenii Stratonikov <evgeniy@nspcc.ru>
Date: Tue, 28 Jul 2020 13:34:14 +0300
Subject: [PATCH] core/tests: refactor getting contract state

Get 2 contracts in pair which is useful everytime we need to test
syscall with one contract calling the other.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
---
 pkg/core/interop_system_test.go | 37 ++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/pkg/core/interop_system_test.go b/pkg/core/interop_system_test.go
index 66c9b29c2..b96b0d463 100644
--- a/pkg/core/interop_system_test.go
+++ b/pkg/core/interop_system_test.go
@@ -325,7 +325,8 @@ func TestBlockchainGetContractState(t *testing.T) {
 	})
 }
 
-func getTestContractState() *state.Contract {
+// getTestContractState returns 2 contracts second of which is allowed to call the first.
+func getTestContractState() (*state.Contract, *state.Contract) {
 	script := []byte{
 		byte(opcode.ABORT), // abort if no offset was provided
 		byte(opcode.ADD), byte(opcode.RET),
@@ -371,11 +372,25 @@ func getTestContractState() *state.Contract {
 			ReturnType: smartcontract.IntegerType,
 		},
 	}
-	return &state.Contract{
+	cs := &state.Contract{
 		Script:   script,
 		Manifest: *m,
 		ID:       42,
 	}
+
+	currScript := []byte{byte(opcode.NOP)}
+	m = manifest.NewManifest(hash.Hash160(currScript))
+	perm := manifest.NewPermission(manifest.PermissionHash, h)
+	perm.Methods.Add("add")
+	perm.Methods.Add("drop")
+	perm.Methods.Add("add3")
+	m.Permissions = append(m.Permissions, *perm)
+
+	return cs, &state.Contract{
+		Script:   currScript,
+		Manifest: *m,
+		ID:       123,
+	}
 }
 
 func loadScript(script []byte, args ...interface{}) *vm.VM {
@@ -392,24 +407,12 @@ func TestContractCall(t *testing.T) {
 	_, ic, bc := createVM(t)
 	defer bc.Close()
 
-	cs := getTestContractState()
+	cs, currCs := getTestContractState()
 	require.NoError(t, ic.DAO.PutContractState(cs))
+	require.NoError(t, ic.DAO.PutContractState(currCs))
 
-	currScript := []byte{byte(opcode.NOP)}
-
+	currScript := currCs.Script
 	h := cs.Manifest.ABI.Hash
-	m := manifest.NewManifest(hash.Hash160(currScript))
-	perm := manifest.NewPermission(manifest.PermissionHash, h)
-	perm.Methods.Add("add")
-	perm.Methods.Add("drop")
-	perm.Methods.Add("add3")
-	m.Permissions = append(m.Permissions, *perm)
-
-	require.NoError(t, ic.DAO.PutContractState(&state.Contract{
-		Script:   currScript,
-		Manifest: *m,
-		ID:       123,
-	}))
 
 	addArgs := stackitem.NewArray([]stackitem.Item{stackitem.Make(1), stackitem.Make(2)})
 	t.Run("Good", func(t *testing.T) {