aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

native: use ABORT in Koblitz multisig

Browse source 
Make the script a bit shorter. ABORTMSG would cost a bit more.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This commit is contained in:
Roman Khimov 2024-05-03 15:35:10 +03:00 committed by Anna Shaleva
parent 34ee294086
commit fb16891e2a
1 changed files with 64 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

130
pkg/core/native/native_test/cryptolib_verification_test.go
View file

@ -674,7 +674,7 @@ func TestCryptoLib_KoblitzMultisigVerificationScript(t *testing.T) {
} }
// The proposed multisig verification script. // The proposed multisig verification script.
// (266 bytes, 8390070 GAS including Invocation script execution for 3/4 multisig). // (264 bytes, 8390070 GAS including Invocation script execution for 3/4 multisig).
// The user has to sign the keccak256([4-bytes-network-magic-LE, txHash-bytes-BE]). // The user has to sign the keccak256([4-bytes-network-magic-LE, txHash-bytes-BE]).
check(t, buildKoblitzMultisigVerificationScript, constructMessage) check(t, buildKoblitzMultisigVerificationScript, constructMessage)
} }
@ -740,12 +740,12 @@ func buildKoblitzMultisigVerificationScript(t *testing.T, m int, pubs keys.Publi
// Store m. // Store m.
emit.Opcodes(vrf.BinWriter, opcode.STLOC6) emit.Opcodes(vrf.BinWriter, opcode.STLOC6)
// Check the number of signatures is m. Return false if not. // Check the number of signatures is m. Abort the execution if not.
emit.Opcodes(vrf.BinWriter, opcode.DEPTH) // push the number of signatures onto stack. emit.Opcodes(vrf.BinWriter, opcode.DEPTH) // push the number of signatures onto stack.
emit.Opcodes(vrf.BinWriter, opcode.LDLOC6) // load m. emit.Opcodes(vrf.BinWriter, opcode.LDLOC6) // load m.
emit.Instruction(vrf.BinWriter, opcode.JMPEQ, []byte{0}) // here and below short jumps are sufficient. emit.Instruction(vrf.BinWriter, opcode.JMPEQ, []byte{0}) // here and below short jumps are sufficient.
sigsLenCheckEndOffset := vrf.Len() // offset of the signatures count check. sigsLenCheckEndOffset := vrf.Len() // offset of the signatures count check.
emit.Opcodes(vrf.BinWriter, opcode.CLEAR, opcode.PUSHF, opcode.RET) // return if length of the signatures not equal to m. emit.Opcodes(vrf.BinWriter, opcode.ABORT) // abort execution if length of the signatures not equal to m.
// Start the check. // Start the check.
checkStartOffset := vrf.Len() checkStartOffset := vrf.Len()
@ -820,16 +820,16 @@ func buildKoblitzMultisigVerificationScript(t *testing.T, m int, pubs keys.Publi
script[loopConditionOffset-1] = byte(progRetOffset - loopConditionOffset + 2) script[loopConditionOffset-1] = byte(progRetOffset - loopConditionOffset + 2)
return script return script
// Here's an example of the resulting single witness invocation script (266 bytes length, the length may vary depending on m/n): // Here's an example of the resulting single witness invocation script (264 bytes length, the length may vary depending on m/n):
// NEO-GO-VM > loadbase64 EwwhAyGrdKSa2M6xnP2HMGzk4Gu/XffuBthZSuRatmtc0xd6DCECN5etf+pJm7AeaQNlFK0dgheMB4kMEG6v20PHe8JpoYQMIQNCHZPDdLgJyE+cbsj9KPpg/8ZsVtZNtziKDdKnOIV3ggwhAoXJ9JwG0qdjg1ZC/PQCV7PqNq0i9g2nOT+sKg1rqMhzFFcHAHVtwHF2Q24oBUkJQG7AcEHF+6DgAwAAAAABAAAAnhSNQS1RCDAQzotyEHMQdGtuuGxtuJIkQgAYaGvOaWzOahTAHwwPdmVyaWZ5V2l0aEVDRHNhDBQb9XWrEYlohBNhCjWhKIbN4LZsckFifVtSa55zbJx0IrlrbrM= // NEO-GO-VM > loadbase64 EwwhAg1khs9yqTuG8R7dEj8/GhCqKwkL+6shSOczeaHENFo8DCECibz2wVNY1zRkRCbn+Qr87lQFjStnrQrwv1CSoea/91sMIQPiiV+wNGl5g5SVULR+BM/G2n6WO0WrGIsq+GBRqQHYwAwhAuwZz40NwnerrmSusUUgNqsZiv0WFj3KQE1BYd7lU7mDFFcHAHVtwHF2Q24oAzhuwHBBxfug4AMAAAAAAQAAAJ4UjUEtUQgwEM6LchBzEHRrbrhsbbiSJEIAGGhrzmlszmoUwB8MD3ZlcmlmeVdpdGhFQ0RzYQwUG/V1qxGJaIQTYQo1oSiGzeC2bHJBYn1bUmuec2ycdCK5a26z
// READY: loaded 266 instructions // READY: loaded 264 instructions
// NEO-GO-VM 0 > ops // NEO-GO-VM 0 > ops
// INDEX OPCODE PARAMETER // INDEX OPCODE PARAMETER
// 0 PUSH3 << // 0 PUSH3 <<
// 1 PUSHDATA1 0321ab74a49ad8ceb19cfd87306ce4e06bbf5df7ee06d8594ae45ab66b5cd3177a // 1 PUSHDATA1 020d6486cf72a93b86f11edd123f3f1a10aa2b090bfbab2148e73379a1c4345a3c
// 36 PUSHDATA1 023797ad7fea499bb01e69036514ad1d82178c07890c106eafdb43c77bc269a184 // 36 PUSHDATA1 0289bcf6c15358d734644426e7f90afcee54058d2b67ad0af0bf5092a1e6bff75b
// 71 PUSHDATA1 03421d93c374b809c84f9c6ec8fd28fa60ffc66c56d64db7388a0dd2a738857782 // 71 PUSHDATA1 03e2895fb034697983949550b47e04cfc6da7e963b45ab188b2af86051a901d8c0
// 106 PUSHDATA1 0285c9f49c06d2a763835642fcf40257b3ea36ad22f60da7393fac2a0d6ba8c873 // 106 PUSHDATA1 02ec19cf8d0dc277abae64aeb1452036ab198afd16163dca404d4161dee553b983
// 141 PUSH4 // 141 PUSH4
// 142 INITSLOT 7 local, 0 arg // 142 INITSLOT 7 local, 0 arg
// 145 STLOC5 // 145 STLOC5
@ -839,57 +839,55 @@ func buildKoblitzMultisigVerificationScript(t *testing.T, m int, pubs keys.Publi
// 149 STLOC6 // 149 STLOC6
// 150 DEPTH // 150 DEPTH
// 151 LDLOC6 // 151 LDLOC6
// 152 JMPEQ 157 (5/05) // 152 JMPEQ 155 (3/03)
// 154 CLEAR // 154 ABORT
// 155 PUSHF // 155 LDLOC6
// 156 RET // 156 PACK
// 157 LDLOC6 // 157 STLOC0
// 158 PACK // 158 SYSCALL System.Runtime.GetNetwork (c5fba0e0)
// 159 STLOC0 // 163 PUSHINT64 4294967296 (0000000001000000)
// 160 SYSCALL System.Runtime.GetNetwork (c5fba0e0) // 172 ADD
// 165 PUSHINT64 4294967296 (0000000001000000) // 173 PUSH4
// 174 ADD // 174 LEFT
// 175 PUSH4 // 175 SYSCALL System.Runtime.GetScriptContainer (2d510830)
// 176 LEFT // 180 PUSH0
// 177 SYSCALL System.Runtime.GetScriptContainer (2d510830) // 181 PICKITEM
// 182 PUSH0 // 182 CAT
// 183 PICKITEM // 183 STLOC2
// 184 CAT // 184 PUSH0
// 185 STLOC2 // 185 STLOC3
// 186 PUSH0 // 186 PUSH0
// 187 STLOC3 // 187 STLOC4
// 188 PUSH0 // 188 LDLOC3
// 189 STLOC4 // 189 LDLOC6
// 190 LDLOC3 // 190 GE
// 191 LDLOC6 // 191 LDLOC4
// 192 GE // 192 LDLOC5
// 193 LDLOC4 // 193 GE
// 194 LDLOC5 // 194 OR
// 195 GE // 195 JMPIF 261 (66/42)
// 196 OR // 197 PUSHINT8 24 (18)
// 197 JMPIF 263 (66/42) // 199 LDLOC0
// 199 PUSHINT8 24 (18) // 200 LDLOC3
// 201 LDLOC0 // 201 PICKITEM
// 202 LDLOC3 // 202 LDLOC1
// 203 PICKITEM // 203 LDLOC4
// 204 LDLOC1 // 204 PICKITEM
// 205 LDLOC4 // 205 LDLOC2
// 206 PICKITEM // 206 PUSH4
// 207 LDLOC2 // 207 PACK
// 208 PUSH4 // 208 PUSH15
// 209 PACK // 209 PUSHDATA1 766572696679576974684543447361 ("verifyWithECDsa")
// 210 PUSH15 // 226 PUSHDATA1 1bf575ab1189688413610a35a12886cde0b66c72 ("NNToUmdQBe5n8o53BTzjTFAnSEcpouyy3B", "0x726cb6e0cd8628a1350a611384688911ab75f51b")
// 211 PUSHDATA1 766572696679576974684543447361 ("verifyWithECDsa") // 248 SYSCALL System.Contract.Call (627d5b52)
// 228 PUSHDATA1 1bf575ab1189688413610a35a12886cde0b66c72 ("NNToUmdQBe5n8o53BTzjTFAnSEcpouyy3B", "0x726cb6e0cd8628a1350a611384688911ab75f51b") // 253 LDLOC3
// 250 SYSCALL System.Contract.Call (627d5b52) // 254 ADD
// 255 LDLOC3 // 255 STLOC3
// 256 ADD // 256 LDLOC4
// 257 STLOC3 // 257 INC
// 258 LDLOC4 // 258 STLOC4
// 259 INC // 259 JMP 188 (-71/b9)
// 260 STLOC4 // 261 LDLOC3
// 261 JMP 190 (-71/b9) // 262 LDLOC6
// 263 LDLOC3 // 263 NUMEQUAL
// 264 LDLOC6
// 265 NUMEQUAL
} }