From fe3c68b92d86a9fc957518c273e33bb547aada3e Mon Sep 17 00:00:00 2001
From: Roman Khimov <roman@nspcc.ru>
Date: Mon, 12 Jul 2021 11:51:49 +0300
Subject: [PATCH] vm: panic in cloneIfStruct

It's internal, so we can deduplicate code a bit.
---
 pkg/vm/vm.go | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/pkg/vm/vm.go b/pkg/vm/vm.go
index c91d5c881..7ae6d5cdf 100644
--- a/pkg/vm/vm.go
+++ b/pkg/vm/vm.go
@@ -1056,10 +1056,7 @@ func (v *VM) execute(ctx *Context, op opcode.Opcode, parameter []byte) (err erro
 		itemElem := v.estack.Pop()
 		arrElem := v.estack.Pop()
 
-		val, err := cloneIfStruct(itemElem.value, MaxStackSize-v.refs.size)
-		if err != nil {
-			panic(err)
-		}
+		val := cloneIfStruct(itemElem.value, MaxStackSize-v.refs.size)
 
 		switch t := arrElem.value.(type) {
 		case *stackitem.Array:
@@ -1373,19 +1370,12 @@ func (v *VM) execute(ctx *Context, op opcode.Opcode, parameter []byte) (err erro
 			src := t.Value().([]stackitem.Item)
 			arr = make([]stackitem.Item, len(src))
 			for i := range src {
-				arr[i], err = cloneIfStruct(src[i], MaxStackSize-v.refs.size)
-				if err != nil {
-					panic(err)
-				}
+				arr[i] = cloneIfStruct(src[i], MaxStackSize-v.refs.size)
 			}
 		case *stackitem.Map:
 			arr = make([]stackitem.Item, 0, t.Len())
 			for k := range t.Value().([]stackitem.MapElement) {
-				elem, err := cloneIfStruct(t.Value().([]stackitem.MapElement)[k].Value, MaxStackSize-v.refs.size)
-				if err != nil {
-					panic(err)
-				}
-				arr = append(arr, elem)
+				arr = append(arr, cloneIfStruct(t.Value().([]stackitem.MapElement)[k].Value, MaxStackSize-v.refs.size))
 			}
 		default:
 			panic("not a Map, Array or Struct")
@@ -1751,12 +1741,16 @@ func checkMultisig1(v *VM, curve elliptic.Curve, h []byte, pkeys [][]byte, sig [
 	return false
 }
 
-func cloneIfStruct(item stackitem.Item, limit int) (stackitem.Item, error) {
+func cloneIfStruct(item stackitem.Item, limit int) stackitem.Item {
 	switch it := item.(type) {
 	case *stackitem.Struct:
-		return it.Clone(limit)
+		ret, err := it.Clone(limit)
+		if err != nil {
+			panic(err)
+		}
+		return ret
 	default:
-		return it, nil
+		return it
 	}
 }