forked from TrueCloudLab/neoneo-go
f96d9d168e
Oracle responses must use the same set of signers as oracle requests even though the transaction itself is signed by oracle nodes/contract. We can probably improve interop.Context by removing Tx field completely and adding more functionality to Container, but it's not very convenient for VerifyWitness and will require adding more stub-like methods for Block, so Tx is used for now (and we do have it in every relevant case).
262 lines
9 KiB
Go
262 lines
9 KiB
Go
package core
|
|
|
|
import (
|
|
"errors"
|
|
"math"
|
|
"math/big"
|
|
"testing"
|
|
|
|
"github.com/nspcc-dev/neo-go/internal/testchain"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/block"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/interop/interopnames"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/native"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/native/noderoles"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/state"
|
|
"github.com/nspcc-dev/neo-go/pkg/core/transaction"
|
|
"github.com/nspcc-dev/neo-go/pkg/crypto/hash"
|
|
"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
|
|
"github.com/nspcc-dev/neo-go/pkg/io"
|
|
"github.com/nspcc-dev/neo-go/pkg/smartcontract"
|
|
"github.com/nspcc-dev/neo-go/pkg/smartcontract/callflag"
|
|
"github.com/nspcc-dev/neo-go/pkg/smartcontract/manifest"
|
|
"github.com/nspcc-dev/neo-go/pkg/smartcontract/nef"
|
|
"github.com/nspcc-dev/neo-go/pkg/smartcontract/trigger"
|
|
"github.com/nspcc-dev/neo-go/pkg/util"
|
|
"github.com/nspcc-dev/neo-go/pkg/vm"
|
|
"github.com/nspcc-dev/neo-go/pkg/vm/emit"
|
|
"github.com/nspcc-dev/neo-go/pkg/vm/opcode"
|
|
"github.com/nspcc-dev/neo-go/pkg/vm/stackitem"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// getTestContractState returns test contract which uses oracles.
|
|
func getOracleContractState(h util.Uint160, stdHash util.Uint160) *state.Contract {
|
|
w := io.NewBufBinWriter()
|
|
emit.Int(w.BinWriter, 5)
|
|
emit.Opcodes(w.BinWriter, opcode.PACK)
|
|
emit.Int(w.BinWriter, int64(callflag.All))
|
|
emit.String(w.BinWriter, "request")
|
|
emit.Bytes(w.BinWriter, h.BytesBE())
|
|
emit.Syscall(w.BinWriter, interopnames.SystemContractCall)
|
|
emit.Opcodes(w.BinWriter, opcode.DROP)
|
|
emit.Opcodes(w.BinWriter, opcode.RET)
|
|
|
|
// `handle` method aborts if len(userData) == 2
|
|
offset := w.Len()
|
|
emit.Bytes(w.BinWriter, neoOwner.BytesBE())
|
|
emit.Syscall(w.BinWriter, interopnames.SystemRuntimeCheckWitness)
|
|
emit.Instruction(w.BinWriter, opcode.JMPIF, []byte{3})
|
|
emit.Opcodes(w.BinWriter, opcode.ABORT)
|
|
|
|
emit.Opcodes(w.BinWriter, opcode.OVER)
|
|
emit.Opcodes(w.BinWriter, opcode.SIZE)
|
|
emit.Int(w.BinWriter, 2)
|
|
emit.Instruction(w.BinWriter, opcode.JMPNE, []byte{3})
|
|
emit.Opcodes(w.BinWriter, opcode.ABORT)
|
|
emit.Int(w.BinWriter, 4) // url, userData, code, result
|
|
emit.Opcodes(w.BinWriter, opcode.PACK)
|
|
emit.Int(w.BinWriter, 1) // 1 byte (args count for `serialize`)
|
|
emit.Opcodes(w.BinWriter, opcode.PACK) // 1 byte (pack args into array for `serialize`)
|
|
emit.AppCallNoArgs(w.BinWriter, stdHash, "serialize", callflag.All) // 39 bytes
|
|
emit.String(w.BinWriter, "lastOracleResponse")
|
|
emit.Syscall(w.BinWriter, interopnames.SystemStorageGetContext)
|
|
emit.Syscall(w.BinWriter, interopnames.SystemStoragePut)
|
|
emit.Opcodes(w.BinWriter, opcode.RET)
|
|
|
|
m := manifest.NewManifest("TestOracle")
|
|
m.ABI.Methods = []manifest.Method{
|
|
{
|
|
Name: "requestURL",
|
|
Offset: 0,
|
|
Parameters: []manifest.Parameter{
|
|
manifest.NewParameter("url", smartcontract.StringType),
|
|
manifest.NewParameter("filter", smartcontract.StringType),
|
|
manifest.NewParameter("callback", smartcontract.StringType),
|
|
manifest.NewParameter("userData", smartcontract.AnyType),
|
|
manifest.NewParameter("gasForResponse", smartcontract.IntegerType),
|
|
},
|
|
ReturnType: smartcontract.VoidType,
|
|
},
|
|
{
|
|
Name: "handle",
|
|
Offset: offset,
|
|
Parameters: []manifest.Parameter{
|
|
manifest.NewParameter("url", smartcontract.StringType),
|
|
manifest.NewParameter("userData", smartcontract.AnyType),
|
|
manifest.NewParameter("code", smartcontract.IntegerType),
|
|
manifest.NewParameter("result", smartcontract.ByteArrayType),
|
|
},
|
|
ReturnType: smartcontract.VoidType,
|
|
},
|
|
}
|
|
|
|
perm := manifest.NewPermission(manifest.PermissionHash, h)
|
|
perm.Methods.Add("request")
|
|
m.Permissions = append(m.Permissions, *perm)
|
|
|
|
script := w.Bytes()
|
|
ne, err := nef.NewFile(script)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return &state.Contract{
|
|
ContractBase: state.ContractBase{
|
|
NEF: *ne,
|
|
Hash: hash.Hash160(script),
|
|
Manifest: *m,
|
|
ID: 42,
|
|
},
|
|
}
|
|
}
|
|
|
|
func putOracleRequest(t *testing.T, h util.Uint160, bc *Blockchain,
|
|
url string, filter *string, cb string, userData []byte, gas int64) util.Uint256 {
|
|
var filtItem interface{}
|
|
if filter != nil {
|
|
filtItem = *filter
|
|
}
|
|
res, err := invokeContractMethod(bc, gas+50_000_000+5_000_000, h, "requestURL",
|
|
url, filtItem, cb, userData, gas)
|
|
require.NoError(t, err)
|
|
return res.Container
|
|
}
|
|
|
|
func TestOracle_Request(t *testing.T) {
|
|
bc := newTestChain(t)
|
|
|
|
orc := bc.contracts.Oracle
|
|
cs := getOracleContractState(orc.Hash, bc.contracts.Std.Hash)
|
|
require.NoError(t, bc.contracts.Management.PutContractState(bc.dao, cs))
|
|
|
|
gasForResponse := int64(2000_1234)
|
|
var filter = "flt"
|
|
userData := []byte("custom info")
|
|
txHash := putOracleRequest(t, cs.Hash, bc, "url", &filter, "handle", userData, gasForResponse)
|
|
|
|
req, err := orc.GetRequestInternal(bc.dao, 0)
|
|
require.NotNil(t, req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, txHash, req.OriginalTxID)
|
|
require.Equal(t, "url", req.URL)
|
|
require.Equal(t, filter, *req.Filter)
|
|
require.Equal(t, cs.Hash, req.CallbackContract)
|
|
require.Equal(t, "handle", req.CallbackMethod)
|
|
require.Equal(t, uint64(gasForResponse), req.GasForResponse)
|
|
|
|
idList, err := orc.GetIDListInternal(bc.dao, "url")
|
|
require.NoError(t, err)
|
|
require.Equal(t, &native.IDList{0}, idList)
|
|
|
|
// Finish.
|
|
priv, err := keys.NewPrivateKey()
|
|
require.NoError(t, err)
|
|
pub := priv.PublicKey()
|
|
|
|
tx := transaction.New([]byte{byte(opcode.PUSH1)}, 0)
|
|
bl := block.New(bc.config.StateRootInHeader)
|
|
bl.Index = bc.BlockHeight() + 1
|
|
setSigner(tx, testchain.CommitteeScriptHash())
|
|
ic := bc.newInteropContext(trigger.Application, bc.dao, bl, tx)
|
|
ic.SpawnVM()
|
|
ic.VM.LoadScript([]byte{byte(opcode.RET)})
|
|
err = bc.contracts.Designate.DesignateAsRole(ic, noderoles.Oracle, keys.PublicKeys{pub})
|
|
require.NoError(t, err)
|
|
|
|
tx = transaction.New(orc.GetOracleResponseScript(), 0)
|
|
ic.Tx = tx
|
|
ic.Block = bc.newBlock(tx)
|
|
|
|
err = orc.FinishInternal(ic)
|
|
require.True(t, errors.Is(err, native.ErrResponseNotFound), "got: %v", err)
|
|
|
|
resp := &transaction.OracleResponse{
|
|
ID: 12,
|
|
Code: transaction.Success,
|
|
Result: []byte{4, 8, 15, 16, 23, 42},
|
|
}
|
|
tx.Attributes = []transaction.Attribute{{
|
|
Type: transaction.OracleResponseT,
|
|
Value: resp,
|
|
}}
|
|
err = orc.FinishInternal(ic)
|
|
require.True(t, errors.Is(err, native.ErrRequestNotFound), "got: %v", err)
|
|
|
|
// We need to ensure that callback is called thus, executing full script is necessary.
|
|
resp.ID = 0
|
|
ic.VM.LoadScriptWithFlags(tx.Script, callflag.All)
|
|
require.NoError(t, ic.VM.Run())
|
|
|
|
si := ic.DAO.GetStorageItem(cs.ID, []byte("lastOracleResponse"))
|
|
require.NotNil(t, si)
|
|
item, err := stackitem.Deserialize(si)
|
|
require.NoError(t, err)
|
|
arr, ok := item.Value().([]stackitem.Item)
|
|
require.True(t, ok)
|
|
require.Equal(t, []byte("url"), arr[0].Value())
|
|
require.Equal(t, userData, arr[1].Value())
|
|
require.Equal(t, big.NewInt(int64(resp.Code)), arr[2].Value())
|
|
require.Equal(t, resp.Result, arr[3].Value())
|
|
|
|
// Check that processed request is removed during `postPersist`.
|
|
_, err = orc.GetRequestInternal(ic.DAO, 0)
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, orc.PostPersist(ic))
|
|
_, err = orc.GetRequestInternal(ic.DAO, 0)
|
|
require.Error(t, err)
|
|
|
|
t.Run("ErrorOnFinish", func(t *testing.T) {
|
|
const reqID = 1
|
|
|
|
putOracleRequest(t, cs.Hash, bc, "url", nil, "handle", []byte{1, 2}, gasForResponse)
|
|
_, err := orc.GetRequestInternal(bc.dao, reqID) // ensure ID is 1
|
|
require.NoError(t, err)
|
|
|
|
tx = transaction.New(orc.GetOracleResponseScript(), 0)
|
|
tx.Attributes = []transaction.Attribute{{
|
|
Type: transaction.OracleResponseT,
|
|
Value: &transaction.OracleResponse{
|
|
ID: reqID,
|
|
Code: transaction.Success,
|
|
Result: []byte{4, 8, 15, 16, 23, 42},
|
|
},
|
|
}}
|
|
ic := bc.newInteropContext(trigger.Application, bc.dao, bc.newBlock(tx), tx)
|
|
ic.VM = ic.SpawnVM()
|
|
ic.VM.LoadScriptWithFlags(tx.Script, callflag.All)
|
|
require.Error(t, ic.VM.Run())
|
|
|
|
// Request is cleaned up even if callback failed.
|
|
require.NoError(t, orc.PostPersist(ic))
|
|
_, err = orc.GetRequestInternal(ic.DAO, reqID)
|
|
require.Error(t, err)
|
|
})
|
|
t.Run("BadRequest", func(t *testing.T) {
|
|
var doBadRequest = func(t *testing.T, h util.Uint160, url string, filter *string, cb string, userData []byte, gas int64) {
|
|
txHash := putOracleRequest(t, h, bc, url, filter, cb, userData, gas)
|
|
aer, err := bc.GetAppExecResults(txHash, trigger.Application)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 1, len(aer))
|
|
require.Equal(t, vm.FaultState, aer[0].VMState)
|
|
}
|
|
t.Run("non-UTF8 url", func(t *testing.T) {
|
|
doBadRequest(t, cs.Hash, "\xff", nil, "", []byte{1, 2}, gasForResponse)
|
|
})
|
|
t.Run("non-UTF8 filter", func(t *testing.T) {
|
|
var f = "\xff"
|
|
doBadRequest(t, cs.Hash, "url", &f, "", []byte{1, 2}, gasForResponse)
|
|
})
|
|
t.Run("not enough gas", func(t *testing.T) {
|
|
doBadRequest(t, cs.Hash, "url", nil, "", nil, 1000)
|
|
})
|
|
t.Run("disallowed callback", func(t *testing.T) {
|
|
doBadRequest(t, cs.Hash, "url", nil, "_deploy", nil, 1000_0000)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestGetSetPrice(t *testing.T) {
|
|
bc := newTestChain(t)
|
|
testGetSet(t, bc, bc.contracts.Oracle.Hash, "Price",
|
|
native.DefaultOracleRequestPrice, 1, math.MaxInt64)
|
|
}
|