From 3f67606f0244443668e66763daeda7799d4b918c Mon Sep 17 00:00:00 2001 From: Ekaterina Lebedeva Date: Mon, 10 Jun 2024 19:21:25 +0300 Subject: [PATCH] [#144] registry: Fix string generator func in obj info test `rune` is alias for `int32`. `randString()` used `rand.Int()` which returns system-specific non-negative integer number. For 64-bit systems it will be int64. An attempt to cast `int64` to `int32` (`rune`) leads the latter to be a negative number in case of overflow. This caused the resulting string containing unexpected symbols. Signed-off-by: Ekaterina Lebedeva --- internal/registry/obj_info_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/registry/obj_info_test.go b/internal/registry/obj_info_test.go index f53f6db..6cd156f 100644 --- a/internal/registry/obj_info_test.go +++ b/internal/registry/obj_info_test.go @@ -101,7 +101,7 @@ func randomObjectInfo() ObjectInfo { func randString(n int) string { var sb strings.Builder for i := 0; i < n; i++ { - sb.WriteRune('a' + rune(rand.Int())%('z'-'a'+1)) + sb.WriteRune('a' + rune(rand.Int31())%('z'-'a'+1)) } return sb.String() }