achuprov/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Pull requests Activity

[#424] object: Do not store large slices in pool

Browse source 
Dynamically growing an unbounded buffers can cause a large
amount of memory to be pinned and never be freed.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2023-06-02 17:33:51 +03:00 committed by Evgenii Stratonikov
parent 41ab4d070e
commit 0400153b7d
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/services/object/put/pool.go
View file

@ -4,7 +4,10 @@ import (
"sync" "sync"
) )
const defaultAllocSize = 1024 const (
defaultAllocSize = 1024
poolSliceMaxSize = 128 * 1024
)
type payload struct { type payload struct {
Data []byte Data []byte
@ -19,6 +22,9 @@ func getPayload() *payload {
} }
func putPayload(p *payload) { func putPayload(p *payload) {
if cap(p.Data) > poolSliceMaxSize {
return
}
p.Data = p.Data[:0] p.Data = p.Data[:0]
putBytesPool.Put(p) putBytesPool.Put(p)
} }