From ecb6b0793c877ae9a6d1b399a3c364323f77254d Mon Sep 17 00:00:00 2001
From: Evgenii Stratonikov <e.stratonikov@yadro.com>
Date: Thu, 13 Mar 2025 09:34:59 +0300
Subject: [PATCH] [#1671] Use `slices.ContainsFunc()` where possible

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
---
 .../internal/modules/morph/helper/netmap.go         |  8 +++-----
 pkg/network/group.go                                |  7 +++----
 pkg/services/object/acl/v2/util_test.go             |  9 ++-------
 pkg/services/policer/policer_test.go                |  7 +++----
 pkg/services/tree/service.go                        | 13 +++++--------
 5 files changed, 16 insertions(+), 28 deletions(-)

diff --git a/cmd/frostfs-adm/internal/modules/morph/helper/netmap.go b/cmd/frostfs-adm/internal/modules/morph/helper/netmap.go
index fb8f0378..20abaff0 100644
--- a/cmd/frostfs-adm/internal/modules/morph/helper/netmap.go
+++ b/cmd/frostfs-adm/internal/modules/morph/helper/netmap.go
@@ -3,6 +3,7 @@ package helper
 import (
 	"errors"
 	"fmt"
+	"slices"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/commonflags"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph/constants"
@@ -118,11 +119,8 @@ func MergeNetmapConfig(roInvoker *invoker.Invoker, md map[string]any) error {
 		return err
 	}
 	for k, v := range m {
-		for _, key := range NetmapConfigKeys {
-			if k == key {
-				md[k] = v
-				break
-			}
+		if slices.Contains(NetmapConfigKeys, k) {
+			md[k] = v
 		}
 	}
 	return nil
diff --git a/pkg/network/group.go b/pkg/network/group.go
index 9843b14d..5a71e530 100644
--- a/pkg/network/group.go
+++ b/pkg/network/group.go
@@ -3,6 +3,7 @@ package network
 import (
 	"errors"
 	"fmt"
+	"slices"
 	"sort"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/netmap"
@@ -164,10 +165,8 @@ func WriteToNodeInfo(g AddressGroup, ni *netmap.NodeInfo) {
 // at least one common address.
 func (x AddressGroup) Intersects(x2 AddressGroup) bool {
 	for i := range x {
-		for j := range x2 {
-			if x[i].equal(x2[j]) {
-				return true
-			}
+		if slices.ContainsFunc(x2, x[i].equal) {
+			return true
 		}
 	}
 
diff --git a/pkg/services/object/acl/v2/util_test.go b/pkg/services/object/acl/v2/util_test.go
index 4b19cecf..40fce887 100644
--- a/pkg/services/object/acl/v2/util_test.go
+++ b/pkg/services/object/acl/v2/util_test.go
@@ -4,6 +4,7 @@ import (
 	"crypto/ecdsa"
 	"crypto/elliptic"
 	"crypto/rand"
+	"slices"
 	"testing"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/api/acl"
@@ -91,13 +92,7 @@ func TestIsVerbCompatible(t *testing.T) {
 
 	for op, list := range table {
 		for _, verb := range verbs {
-			var contains bool
-			for _, v := range list {
-				if v == verb {
-					contains = true
-					break
-				}
-			}
+			contains := slices.Contains(list, verb)
 
 			tok.ForVerb(verb)
 
diff --git a/pkg/services/policer/policer_test.go b/pkg/services/policer/policer_test.go
index cef4c36d..049c3375 100644
--- a/pkg/services/policer/policer_test.go
+++ b/pkg/services/policer/policer_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"errors"
+	"slices"
 	"sort"
 	"testing"
 	"time"
@@ -226,10 +227,8 @@ func TestProcessObject(t *testing.T) {
 						return nil, err
 					}
 				}
-				for _, i := range ti.objHolders {
-					if index == i {
-						return nil, nil
-					}
+				if slices.Contains(ti.objHolders, index) {
+					return nil, nil
 				}
 				return nil, new(apistatus.ObjectNotFound)
 			}
diff --git a/pkg/services/tree/service.go b/pkg/services/tree/service.go
index f9b7395e..cd89d6a2 100644
--- a/pkg/services/tree/service.go
+++ b/pkg/services/tree/service.go
@@ -345,14 +345,11 @@ func (s *Service) GetNodeByPath(ctx context.Context, req *GetNodeByPathRequest)
 		} else {
 			var metaValue []KeyValue
 			for _, kv := range m.Items {
-				for _, attr := range b.GetAttributes() {
-					if kv.Key == attr {
-						metaValue = append(metaValue, KeyValue{
-							Key:   kv.Key,
-							Value: kv.Value,
-						})
-						break
-					}
+				if slices.Contains(b.GetAttributes(), kv.Key) {
+					metaValue = append(metaValue, KeyValue{
+						Key:   kv.Key,
+						Value: kv.Value,
+					})
 				}
 			}
 			x.Meta = metaValue