Merge pull request #24 from nspcc-dev/fix/get-rid-of-service-sign-and-verify-requests

Get rid of Sign and Verify requests

accounting/withdraw.go

@@ -11,12 +11,6 @@ type (
 	MessageID = refs.MessageID
 )
 
-// SetSignature sets signature to PutRequest to satisfy SignedRequest interface.
-func (m *PutRequest) SetSignature(v []byte) { m.Signature = v }
-
-// SetSignature sets signature to DeleteRequest to satisfy SignedRequest interface.
-func (m *DeleteRequest) SetSignature(v []byte) { m.Signature = v }
-
 // PrepareData prepares bytes representation of PutRequest to satisfy SignedRequest interface.
 func (m *PutRequest) PrepareData() ([]byte, error) {
 	var offset int

accounting/withdraw.proto

@@ -59,8 +59,6 @@ message PutRequest {
     uint64 Height                            = 3;
     // MessageID is a nonce for uniq request (UUIDv4)
     bytes MessageID                          = 4 [(gogoproto.customtype) = "MessageID", (gogoproto.nullable) = false];
-    // Signature is a signature of the sent request
-    bytes Signature                          = 5;
     // RequestMetaHeader contains information about request meta headers (should be embedded into message)
     service.RequestMetaHeader Meta           = 98 [(gogoproto.embed) = true, (gogoproto.nullable) = false];
     // RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message)
@@ -92,8 +90,6 @@ message DeleteRequest {
     bytes OwnerID                            = 2 [(gogoproto.customtype) = "OwnerID", (gogoproto.nullable) = false];
     // MessageID is a nonce for uniq request (UUIDv4)
     bytes MessageID                          = 3 [(gogoproto.customtype) = "MessageID", (gogoproto.nullable) = false];
-    // Signature is a signature of the sent request
-    bytes Signature                          = 4;
     // RequestMetaHeader contains information about request meta headers (should be embedded into message)
     service.RequestMetaHeader Meta           = 98 [(gogoproto.embed) = true, (gogoproto.nullable) = false];
     // RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message)

container/service.go

@@ -25,12 +25,6 @@ const (
 	ErrNotFound = internal.Error("could not find container")
 )
 
-// SetSignature sets signature to PutRequest to satisfy SignedRequest interface.
-func (m *PutRequest) SetSignature(v []byte) { m.Signature = v }
-
-// SetSignature sets signature to DeleteRequest to satisfy SignedRequest interface.
-func (m *DeleteRequest) SetSignature(v []byte) { m.Signature = v }
-
 // PrepareData prepares bytes representation of PutRequest to satisfy SignedRequest interface.
 func (m *PutRequest) PrepareData() ([]byte, error) {
 	var (

container/service.proto

@@ -41,9 +41,6 @@ message PutRequest {
     // Rules define storage policy for the object inside the container.
     netmap.PlacementRule rules               = 4 [(gogoproto.nullable) = false];
 
-    // Signature of the user (owner id)
-    bytes Signature                          = 5;
-
     // RequestMetaHeader contains information about request meta headers (should be embedded into message)
     service.RequestMetaHeader Meta           = 98 [(gogoproto.embed) = true, (gogoproto.nullable) = false];
     // RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message)
@@ -59,9 +56,6 @@ message DeleteRequest {
     // CID (container id) is a SHA256 hash of the container structure
     bytes CID                                = 1 [(gogoproto.customtype) = "CID", (gogoproto.nullable) = false];
 
-    // Signature of the container owner
-    bytes Signature                          = 2;
-
     // RequestMetaHeader contains information about request meta headers (should be embedded into message)
     service.RequestMetaHeader Meta           = 98 [(gogoproto.embed) = true, (gogoproto.nullable) = false];
     // RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message)

docs/accounting.md

@@ -362,7 +362,6 @@ Delete allows user to remove unused cheque
 | ID | [bytes](#bytes) |  | ID is cheque identifier |
 | OwnerID | [bytes](#bytes) |  | OwnerID is a wallet address |
 | MessageID | [bytes](#bytes) |  | MessageID is a nonce for uniq request (UUIDv4) |
-| Signature | [bytes](#bytes) |  | Signature is a signature of the sent request |
 | Meta | [service.RequestMetaHeader](#service.RequestMetaHeader) |  | RequestMetaHeader contains information about request meta headers (should be embedded into message) |
 | Verify | [service.RequestVerificationHeader](#service.RequestVerificationHeader) |  | RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message) |
 
@@ -450,7 +449,6 @@ DeleteResponse is empty
 | Amount | [decimal.Decimal](#decimal.Decimal) |  | Amount of funds |
 | Height | [uint64](#uint64) |  | Height is the neo blockchain height until the cheque is valid |
 | MessageID | [bytes](#bytes) |  | MessageID is a nonce for uniq request (UUIDv4) |
-| Signature | [bytes](#bytes) |  | Signature is a signature of the sent request |
 | Meta | [service.RequestMetaHeader](#service.RequestMetaHeader) |  | RequestMetaHeader contains information about request meta headers (should be embedded into message) |
 | Verify | [service.RequestVerificationHeader](#service.RequestVerificationHeader) |  | RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message) |
 

docs/container.md

@@ -92,7 +92,6 @@ List returns all user's containers
 | Field | Type | Label | Description |
 | ----- | ---- | ----- | ----------- |
 | CID | [bytes](#bytes) |  | CID (container id) is a SHA256 hash of the container structure |
-| Signature | [bytes](#bytes) |  | Signature of the container owner |
 | Meta | [service.RequestMetaHeader](#service.RequestMetaHeader) |  | RequestMetaHeader contains information about request meta headers (should be embedded into message) |
 | Verify | [service.RequestVerificationHeader](#service.RequestVerificationHeader) |  | RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message) |
 
@@ -165,7 +164,6 @@ via consensus in inner ring nodes
 | Capacity | [uint64](#uint64) |  | Capacity defines amount of data that can be stored in the container (doesn't used for now). |
 | OwnerID | [bytes](#bytes) |  | OwnerID is a wallet address |
 | rules | [netmap.PlacementRule](#netmap.PlacementRule) |  | Rules define storage policy for the object inside the container. |
-| Signature | [bytes](#bytes) |  | Signature of the user (owner id) |
 | Meta | [service.RequestMetaHeader](#service.RequestMetaHeader) |  | RequestMetaHeader contains information about request meta headers (should be embedded into message) |
 | Verify | [service.RequestVerificationHeader](#service.RequestVerificationHeader) |  | RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message) |