From 4248424a4452473c53ed682de4f535f68a0da7ad Mon Sep 17 00:00:00 2001 From: Evgenii Stratonikov Date: Mon, 22 Nov 2021 12:42:28 +0300 Subject: [PATCH] nns: disallow conflicting records on register Require no records '*.domain' to be present when registering domain. Signed-off-by: Evgenii Stratonikov --- nns/nns_contract.go | 11 +++++++++++ tests/nns_test.go | 10 ++++++++++ 2 files changed, 21 insertions(+) diff --git a/nns/nns_contract.go b/nns/nns_contract.go index dea6adc..6824549 100644 --- a/nns/nns_contract.go +++ b/nns/nns_contract.go @@ -298,6 +298,17 @@ func Register(name string, owner interop.Hash160, email string, refresh, retry, nsBytes := storage.Get(ctx, append([]byte{prefixName}, parentKey...)) ns := std.Deserialize(nsBytes.([]byte)).(NameState) ns.checkAdmin() + + parentRecKey := append([]byte{prefixRecord}, parentKey...) + it := storage.Find(ctx, parentRecKey, storage.ValuesOnly|storage.DeserializeValues) + suffix := []byte(name) + for iterator.Next(it) { + r := iterator.Value(it).(RecordState) + ind := std.MemorySearchLastIndex([]byte(r.Name), suffix, len(r.Name)) + if ind > 0 && ind+len(suffix) == len(r.Name) { + panic("parent domain has conflicting records: " + r.Name) + } + } } if !isValid(owner) { diff --git a/tests/nns_test.go b/tests/nns_test.go index c8aa5eb..cefc2b1 100644 --- a/tests/nns_test.go +++ b/tests/nns_test.go @@ -166,7 +166,17 @@ func TestNNSRegisterMulti(t *testing.T) { args = newArgs("mainnet.fs.neo.com", acc2) c2.InvokeFail(t, "not witnessed by admin", "register", args...) + c1.Invoke(t, stackitem.Null{}, "addRecord", + "something.mainnet.fs.neo.com", int64(nns.A), "1.2.3.4") + c1.Invoke(t, stackitem.Null{}, "addRecord", + "another.fs.neo.com", int64(nns.A), "4.3.2.1") + c2 = c.WithSigners(acc, acc2) + c2.InvokeFail(t, "parent domain has conflicting records: something.mainnet.fs.neo.com", + "register", args...) + + c1.Invoke(t, stackitem.Null{}, "deleteRecords", + "something.mainnet.fs.neo.com", int64(nns.A)) c2.Invoke(t, true, "register", args...) c2 = c.WithSigners(acc2)