forked from TrueCloudLab/frostfs-node
[#69] object/acl: Construct service from options
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
parent
e5898c9ca8
commit
30e6912c7b
3 changed files with 74 additions and 28 deletions
|
@ -292,11 +292,16 @@ func initObjectService(c *cfg) {
|
|||
objectGRPC.RegisterObjectServiceServer(c.cfgGRPC.server,
|
||||
objectTransportGRPC.New(
|
||||
acl.New(
|
||||
acl.WithSenderClassifier(
|
||||
acl.NewSenderClassifier(
|
||||
c.cfgNetmap.wrapper,
|
||||
c.cfgNetmap.wrapper,
|
||||
),
|
||||
),
|
||||
acl.WithContainerSource(
|
||||
c.cfgObject.cnrStorage,
|
||||
),
|
||||
acl.WithNextService(
|
||||
objectService.NewSignService(
|
||||
c.key,
|
||||
objectService.NewTransportSplitter(
|
||||
|
@ -315,5 +320,6 @@ func initObjectService(c *cfg) {
|
|||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
)
|
||||
}
|
||||
|
|
|
@ -16,9 +16,7 @@ import (
|
|||
type (
|
||||
// Service checks basic ACL rules.
|
||||
Service struct {
|
||||
containers core.Source
|
||||
sender SenderClassifier
|
||||
next object.Service
|
||||
*cfg
|
||||
}
|
||||
|
||||
putStreamBasicChecker struct {
|
||||
|
@ -47,6 +45,17 @@ type (
|
|||
}
|
||||
)
|
||||
|
||||
// Option represents Service constructor option.
|
||||
type Option func(*cfg)
|
||||
|
||||
type cfg struct {
|
||||
containers core.Source
|
||||
|
||||
sender SenderClassifier
|
||||
|
||||
next object.Service
|
||||
}
|
||||
|
||||
var (
|
||||
ErrMalformedRequest = errors.New("malformed request")
|
||||
ErrUnknownRole = errors.New("can't classify request sender")
|
||||
|
@ -54,16 +63,20 @@ var (
|
|||
ErrBasicAccessDenied = errors.New("access denied by basic acl")
|
||||
)
|
||||
|
||||
func defaultCfg() *cfg {
|
||||
return new(cfg)
|
||||
}
|
||||
|
||||
// New is a constructor for object ACL checking service.
|
||||
func New(
|
||||
c SenderClassifier,
|
||||
cnr core.Source,
|
||||
next object.Service) Service {
|
||||
func New(opts ...Option) Service {
|
||||
cfg := defaultCfg()
|
||||
|
||||
for i := range opts {
|
||||
opts[i](cfg)
|
||||
}
|
||||
|
||||
return Service{
|
||||
containers: cnr,
|
||||
sender: c,
|
||||
next: next,
|
||||
cfg: cfg,
|
||||
}
|
||||
}
|
||||
|
||||
|
|
27
pkg/services/object/acl/opts.go
Normal file
27
pkg/services/object/acl/opts.go
Normal file
|
@ -0,0 +1,27 @@
|
|||
package acl
|
||||
|
||||
import (
|
||||
"github.com/nspcc-dev/neofs-api-go/v2/object"
|
||||
"github.com/nspcc-dev/neofs-node/pkg/core/container"
|
||||
)
|
||||
|
||||
// WithContainerSource returns option to set container source.
|
||||
func WithContainerSource(v container.Source) Option {
|
||||
return func(c *cfg) {
|
||||
c.containers = v
|
||||
}
|
||||
}
|
||||
|
||||
// WithSenderClassifier returns option to set sender classifier.
|
||||
func WithSenderClassifier(v SenderClassifier) Option {
|
||||
return func(c *cfg) {
|
||||
c.sender = v
|
||||
}
|
||||
}
|
||||
|
||||
// WithNextService returns option to set next object service.
|
||||
func WithNextService(v object.Service) Option {
|
||||
return func(c *cfg) {
|
||||
c.next = v
|
||||
}
|
||||
}
|
Loading…
Reference in a new issue