From c09c70161395b5d34dc4ea128fc63877e5d1f773 Mon Sep 17 00:00:00 2001
From: Dmitrii Stepanov <d.stepanov@yadro.com>
Date: Tue, 19 Mar 2024 11:49:19 +0300
Subject: [PATCH] [#1048] metabase: Fix drop buckets during resync

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
---
 pkg/local_object_storage/metabase/control.go  | 46 ++++++++-------
 .../metabase/reset_test.go                    | 57 +++++++++++++++++++
 2 files changed, 82 insertions(+), 21 deletions(-)
 create mode 100644 pkg/local_object_storage/metabase/reset_test.go

diff --git a/pkg/local_object_storage/metabase/control.go b/pkg/local_object_storage/metabase/control.go
index a275f456..83b0b11b 100644
--- a/pkg/local_object_storage/metabase/control.go
+++ b/pkg/local_object_storage/metabase/control.go
@@ -21,6 +21,22 @@ var ErrDegradedMode = logicerr.New("metabase is in a degraded mode")
 // ErrReadOnlyMode is returned when metabase is in a read-only mode.
 var ErrReadOnlyMode = logicerr.New("metabase is in a read-only mode")
 
+var (
+	mStaticBuckets = map[string]struct{}{
+		string(containerVolumeBucketName):  {},
+		string(containerCounterBucketName): {},
+		string(graveyardBucketName):        {},
+		string(garbageBucketName):          {},
+		string(shardInfoBucket):            {},
+		string(bucketNameLocked):           {},
+	}
+
+	// deprecatedBuckets buckets that are not used anymore.
+	deprecatedBuckets = [][]byte{
+		toMoveItBucketName,
+	}
+)
+
 // Open boltDB instance for metabase.
 func (db *DB) Open(_ context.Context, mode mode.Mode) error {
 	db.modeMtx.Lock()
@@ -113,20 +129,6 @@ func (db *DB) init(reset bool) error {
 		return nil
 	}
 
-	mStaticBuckets := map[string]struct{}{
-		string(containerVolumeBucketName):  {},
-		string(containerCounterBucketName): {},
-		string(graveyardBucketName):        {},
-		string(garbageBucketName):          {},
-		string(shardInfoBucket):            {},
-		string(bucketNameLocked):           {},
-	}
-
-	// buckets that are not used anymore
-	deprecatedBuckets := [][]byte{
-		toMoveItBucketName,
-	}
-
 	return db.boltDB.Update(func(tx *bbolt.Tx) error {
 		var err error
 		if !reset {
@@ -167,15 +169,17 @@ func (db *DB) init(reset bool) error {
 			return nil
 		}
 
-		err = tx.ForEach(func(name []byte, _ *bbolt.Bucket) error {
+		bucketCursor := tx.Cursor()
+		name, _ := bucketCursor.First()
+		for name != nil {
 			if _, ok := mStaticBuckets[string(name)]; !ok {
-				return tx.DeleteBucket(name)
+				if err := tx.DeleteBucket(name); err != nil {
+					return err
+				}
+				name, _ = bucketCursor.Seek(name)
+				continue
 			}
-
-			return nil
-		})
-		if err != nil {
-			return err
+			name, _ = bucketCursor.Next()
 		}
 		return updateVersion(tx, version)
 	})
diff --git a/pkg/local_object_storage/metabase/reset_test.go b/pkg/local_object_storage/metabase/reset_test.go
new file mode 100644
index 00000000..66f5eefc
--- /dev/null
+++ b/pkg/local_object_storage/metabase/reset_test.go
@@ -0,0 +1,57 @@
+package meta
+
+import (
+	"context"
+	"fmt"
+	"path/filepath"
+	"testing"
+
+	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/testutil"
+	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode"
+	"github.com/stretchr/testify/require"
+	"go.etcd.io/bbolt"
+)
+
+type epochState struct{ e uint64 }
+
+func (s epochState) CurrentEpoch() uint64 {
+	return s.e
+}
+
+func TestResetDropsContainerBuckets(t *testing.T) {
+	t.Parallel()
+
+	db := New(
+		[]Option{
+			WithPath(filepath.Join(t.TempDir(), "metabase")),
+			WithPermissions(0o600),
+			WithEpochState(epochState{}),
+		}...,
+	)
+
+	require.NoError(t, db.Open(context.Background(), mode.ReadWrite))
+	require.NoError(t, db.Init())
+
+	defer func() { require.NoError(t, db.Close()) }()
+
+	for idx := 0; idx < 100; idx++ {
+		var putPrm PutPrm
+		putPrm.SetObject(testutil.GenerateObject())
+		putPrm.SetStorageID([]byte(fmt.Sprintf("0/%d", idx)))
+		_, err := db.Put(context.Background(), putPrm)
+		require.NoError(t, err)
+	}
+
+	require.NoError(t, db.Reset())
+
+	var bucketCount int
+	require.NoError(t, db.boltDB.Update(func(tx *bbolt.Tx) error {
+		return tx.ForEach(func(name []byte, b *bbolt.Bucket) error {
+			_, exists := mStaticBuckets[string(name)]
+			require.True(t, exists, "unexpected bucket:"+string(name))
+			bucketCount++
+			return nil
+		})
+	}))
+	require.Equal(t, len(mStaticBuckets), bucketCount)
+}