From cedbd380f27c5d1d9e369eb04139103592965a24 Mon Sep 17 00:00:00 2001 From: Evgenii Stratonikov Date: Wed, 11 Jan 2023 13:08:12 +0300 Subject: [PATCH] [#2197] pilorama: Close database in degraded mode Signed-off-by: Evgenii Stratonikov --- CHANGELOG.md | 2 + pkg/local_object_storage/pilorama/boltdb.go | 94 +++++++++++++++++++-- 2 files changed, 90 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db69b5841..67fa8a418 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ Changelog for FrostFS Node ### Changed ### Fixed - Big object removal with non-local parts (#1978) +- Disable pilorama when moving to degraded mode (#2197) + ### Removed ### Updated - `neo-go` to `v0.100.1` diff --git a/pkg/local_object_storage/pilorama/boltdb.go b/pkg/local_object_storage/pilorama/boltdb.go index 3fb67d326..d3c13942e 100644 --- a/pkg/local_object_storage/pilorama/boltdb.go +++ b/pkg/local_object_storage/pilorama/boltdb.go @@ -12,6 +12,7 @@ import ( "time" "github.com/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode" + "github.com/TrueCloudLab/frostfs-node/pkg/local_object_storage/util/logicerr" "github.com/TrueCloudLab/frostfs-node/pkg/util" cidSDK "github.com/TrueCloudLab/frostfs-sdk-go/container/id" "github.com/nspcc-dev/neo-go/pkg/io" @@ -21,7 +22,7 @@ import ( type boltForest struct { db *bbolt.DB - modeMtx sync.Mutex + modeMtx sync.RWMutex mode mode.Mode cfg } @@ -31,6 +32,12 @@ var ( logBucket = []byte{1} ) +// ErrDegradedMode is returned when pilorama is in a degraded mode. +var ErrDegradedMode = logicerr.New("pilorama is in a degraded mode") + +// ErrReadOnlyMode is returned when pilorama is in a read-only mode. +var ErrReadOnlyMode = logicerr.New("pilorama is in a read-only mode") + // NewBoltForest returns storage wrapper for storing operations on CRDT trees. // // Each tree is stored in a separate bucket by `CID + treeID` key. @@ -71,12 +78,9 @@ func (t *boltForest) SetMode(m mode.Mode) error { if t.mode == m { return nil } - if t.mode.ReadOnly() == m.ReadOnly() { - return nil - } err := t.Close() - if err == nil { + if err == nil && !m.NoMetabase() { if err = t.Open(m.ReadOnly()); err == nil { err = t.Init() } @@ -110,7 +114,7 @@ func (t *boltForest) Open(readOnly bool) error { return nil } func (t *boltForest) Init() error { - if t.db.IsReadOnly() { + if t.mode.NoMetabase() || t.db.IsReadOnly() { return nil } return t.db.Update(func(tx *bbolt.Tx) error { @@ -138,6 +142,15 @@ func (t *boltForest) TreeMove(d CIDDescriptor, treeID string, m *Move) (*LogMove return nil, ErrInvalidCIDDescriptor } + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return nil, ErrDegradedMode + } else if t.mode.ReadOnly() { + return nil, ErrReadOnlyMode + } + var lm LogMove lm.Move = *m return &lm, t.db.Batch(func(tx *bbolt.Tx) error { @@ -156,6 +169,13 @@ func (t *boltForest) TreeMove(d CIDDescriptor, treeID string, m *Move) (*LogMove // TreeExists implements the Forest interface. func (t *boltForest) TreeExists(cid cidSDK.ID, treeID string) (bool, error) { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return false, ErrDegradedMode + } + var exists bool err := t.db.View(func(tx *bbolt.Tx) error { @@ -176,6 +196,15 @@ func (t *boltForest) TreeAddByPath(d CIDDescriptor, treeID string, attr string, return nil, ErrNotPathAttribute } + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return nil, ErrDegradedMode + } else if t.mode.ReadOnly() { + return nil, ErrReadOnlyMode + } + var lm []LogMove var key [17]byte @@ -260,6 +289,15 @@ func (t *boltForest) TreeApply(d CIDDescriptor, treeID string, m *Move, backgrou return ErrInvalidCIDDescriptor } + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return ErrDegradedMode + } else if t.mode.ReadOnly() { + return ErrReadOnlyMode + } + if backgroundSync { var seen bool err := t.db.View(func(tx *bbolt.Tx) error { @@ -508,6 +546,13 @@ func (t *boltForest) TreeGetByPath(cid cidSDK.ID, treeID string, attr string, pa return nil, nil } + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return nil, ErrDegradedMode + } + var nodes []Node return nodes, t.db.View(func(tx *bbolt.Tx) error { @@ -555,6 +600,13 @@ func (t *boltForest) TreeGetByPath(cid cidSDK.ID, treeID string, attr string, pa // TreeGetMeta implements the forest interface. func (t *boltForest) TreeGetMeta(cid cidSDK.ID, treeID string, nodeID Node) (Meta, Node, error) { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return Meta{}, 0, ErrDegradedMode + } + key := parentKey(make([]byte, 9), nodeID) var m Meta @@ -578,6 +630,13 @@ func (t *boltForest) TreeGetMeta(cid cidSDK.ID, treeID string, nodeID Node) (Met // TreeGetChildren implements the Forest interface. func (t *boltForest) TreeGetChildren(cid cidSDK.ID, treeID string, nodeID Node) ([]uint64, error) { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return nil, ErrDegradedMode + } + key := make([]byte, 9) key[0] = 'c' binary.LittleEndian.PutUint64(key[1:], nodeID) @@ -603,6 +662,13 @@ func (t *boltForest) TreeGetChildren(cid cidSDK.ID, treeID string, nodeID Node) // TreeList implements the Forest interface. func (t *boltForest) TreeList(cid cidSDK.ID) ([]string, error) { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return nil, ErrDegradedMode + } + var ids []string cidRaw := []byte(cid.EncodeToString()) cidLen := len(cidRaw) @@ -628,6 +694,13 @@ func (t *boltForest) TreeList(cid cidSDK.ID) ([]string, error) { // TreeGetOpLog implements the pilorama.Forest interface. func (t *boltForest) TreeGetOpLog(cid cidSDK.ID, treeID string, height uint64) (Move, error) { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return Move{}, ErrDegradedMode + } + key := make([]byte, 8) binary.BigEndian.PutUint64(key, height) @@ -651,6 +724,15 @@ func (t *boltForest) TreeGetOpLog(cid cidSDK.ID, treeID string, height uint64) ( // TreeDrop implements the pilorama.Forest interface. func (t *boltForest) TreeDrop(cid cidSDK.ID, treeID string) error { + t.modeMtx.RLock() + defer t.modeMtx.RUnlock() + + if t.mode.NoMetabase() { + return ErrDegradedMode + } else if t.mode.ReadOnly() { + return ErrReadOnlyMode + } + return t.db.Batch(func(tx *bbolt.Tx) error { if treeID == "" { c := tx.Cursor()