forked from TrueCloudLab/frostfs-node
[#1143] shard: Handle some errors in degraded mode
If metabase is corrupted for some reason, failback to checking blobstor directly. Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
This commit is contained in:
parent
08e7914729
commit
f058cead8f
1 changed files with 20 additions and 5 deletions
|
@ -1,8 +1,10 @@
|
||||||
package shard
|
package shard
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"github.com/nspcc-dev/neofs-node/pkg/local_object_storage/blobstor"
|
||||||
meta "github.com/nspcc-dev/neofs-node/pkg/local_object_storage/metabase"
|
meta "github.com/nspcc-dev/neofs-node/pkg/local_object_storage/metabase"
|
||||||
addressSDK "github.com/nspcc-dev/neofs-sdk-go/object/address"
|
addressSDK "github.com/nspcc-dev/neofs-sdk-go/object/address"
|
||||||
|
"go.uber.org/zap"
|
||||||
)
|
)
|
||||||
|
|
||||||
// ExistsPrm groups the parameters of Exists operation.
|
// ExistsPrm groups the parameters of Exists operation.
|
||||||
|
@ -36,13 +38,26 @@ func (p *ExistsRes) Exists() bool {
|
||||||
//
|
//
|
||||||
// Returns an error of type apistatus.ObjectAlreadyRemoved if object has been marked as removed.
|
// Returns an error of type apistatus.ObjectAlreadyRemoved if object has been marked as removed.
|
||||||
func (s *Shard) Exists(prm *ExistsPrm) (*ExistsRes, error) {
|
func (s *Shard) Exists(prm *ExistsPrm) (*ExistsRes, error) {
|
||||||
exists, err := s.objectExists(prm.addr)
|
exists, err := meta.Exists(s.metaBase, prm.addr)
|
||||||
|
if err != nil {
|
||||||
|
// If the shard is in degraded mode, try to consult blobstor directly.
|
||||||
|
// Otherwise, just return an error.
|
||||||
|
if s.GetMode() == ModeDegraded {
|
||||||
|
p := new(blobstor.ExistsPrm)
|
||||||
|
p.SetAddress(prm.addr)
|
||||||
|
|
||||||
|
res, bErr := s.blobStor.Exists(p)
|
||||||
|
if bErr == nil {
|
||||||
|
exists = res.Exists()
|
||||||
|
s.log.Warn("metabase existence check finished with error",
|
||||||
|
zap.Stringer("address", prm.addr),
|
||||||
|
zap.String("error", err.Error()))
|
||||||
|
err = nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return &ExistsRes{
|
return &ExistsRes{
|
||||||
ex: exists,
|
ex: exists,
|
||||||
}, err
|
}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *Shard) objectExists(addr *addressSDK.Address) (bool, error) {
|
|
||||||
return meta.Exists(s.metaBase, addr)
|
|
||||||
}
|
|
||||||
|
|
Loading…
Reference in a new issue