From c8b8b3cadfd0927ca66d0809d4ba0a250a33d584 Mon Sep 17 00:00:00 2001 From: Logan Pulley Date: Wed, 12 Oct 2022 11:35:06 -0500 Subject: [PATCH] Double-quote `$GITHUB_OUTPUT` --- .github/workflows/manual-matrix-test.yml | 2 +- diff-sha.sh | 8 ++-- get-base-sha.sh | 4 +- get-changed-paths.sh | 54 ++++++++++++------------ get-sha.sh | 4 +- 5 files changed, 36 insertions(+), 36 deletions(-) diff --git a/.github/workflows/manual-matrix-test.yml b/.github/workflows/manual-matrix-test.yml index ddd05f87..626947b7 100644 --- a/.github/workflows/manual-matrix-test.yml +++ b/.github/workflows/manual-matrix-test.yml @@ -24,7 +24,7 @@ jobs: echo '${{ steps.changed-files.outputs.all_changed_files }}' - id: set-matrix - run: echo "matrix={\"container\":${{ steps.changed-files.outputs.all_changed_files }}}" >>$GITHUB_OUTPUT + run: echo "matrix={\"container\":${{ steps.changed-files.outputs.all_changed_files }}}" >>"$GITHUB_OUTPUT" matrix-job: name: Run Matrix Job diff --git a/diff-sha.sh b/diff-sha.sh index caedc704..9268ff08 100644 --- a/diff-sha.sh +++ b/diff-sha.sh @@ -133,9 +133,9 @@ if [[ -n "$PREVIOUS_SHA" && -n "$CURRENT_SHA" && "$PREVIOUS_SHA" == "$CURRENT_SH exit 1 fi -echo "target_branch=$TARGET_BRANCH" >>$GITHUB_OUTPUT -echo "current_branch=$CURRENT_BRANCH" >>$GITHUB_OUTPUT -echo "previous_sha=$PREVIOUS_SHA" >>$GITHUB_OUTPUT -echo "current_sha=$CURRENT_SHA" >>$GITHUB_OUTPUT +echo "target_branch=$TARGET_BRANCH" >>"$GITHUB_OUTPUT" +echo "current_branch=$CURRENT_BRANCH" >>"$GITHUB_OUTPUT" +echo "previous_sha=$PREVIOUS_SHA" >>"$GITHUB_OUTPUT" +echo "current_sha=$CURRENT_SHA" >>"$GITHUB_OUTPUT" echo "::endgroup::" diff --git a/get-base-sha.sh b/get-base-sha.sh index 92a785ee..750e6abb 100644 --- a/get-base-sha.sh +++ b/get-base-sha.sh @@ -18,7 +18,7 @@ if [[ -n "$INPUT_SINCE" ]]; then if [[ -z "$BASE_SHA" ]]; then echo "::warning::The BASE_SHA for date '$INPUT_SINCE' couldn't be determined." fi - echo "base_sha=$BASE_SHA" >>$GITHUB_OUTPUT + echo "base_sha=$BASE_SHA" >>"$GITHUB_OUTPUT" elif [[ -n "$INPUT_BASE_SHA" ]]; then - echo "base_sha=$INPUT_BASE_SHA" >>$GITHUB_OUTPUT + echo "base_sha=$INPUT_BASE_SHA" >>"$GITHUB_OUTPUT" fi diff --git a/get-changed-paths.sh b/get-changed-paths.sh index a070efad..3adf7e4f 100755 --- a/get-changed-paths.sh +++ b/get-changed-paths.sh @@ -131,9 +131,9 @@ else if [[ -n "${ALL_CHANGED}" ]]; then echo "::debug::Matching changed files: ${ALL_CHANGED}" - echo "any_changed=true" >>$GITHUB_OUTPUT + echo "any_changed=true" >>"$GITHUB_OUTPUT" else - echo "any_changed=false" >>$GITHUB_OUTPUT + echo "any_changed=false" >>"$GITHUB_OUTPUT" fi OTHER_CHANGED="" @@ -154,19 +154,19 @@ else if [[ -n "${OTHER_CHANGED}" && "${OTHER_CHANGED}" != "[]" ]]; then echo "::debug::Non Matching changed files: ${OTHER_CHANGED}" - echo "only_changed=false" >>$GITHUB_OUTPUT - echo "other_changed_files=$OTHER_CHANGED" >>$GITHUB_OUTPUT + echo "only_changed=false" >>"$GITHUB_OUTPUT" + echo "other_changed_files=$OTHER_CHANGED" >>"$GITHUB_OUTPUT" elif [[ -n "${ALL_CHANGED}" ]]; then - echo "only_changed=true" >>$GITHUB_OUTPUT + echo "only_changed=true" >>"$GITHUB_OUTPUT" fi ALL_OTHER_MODIFIED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" "ACMRD" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}') if [[ -n "${ALL_MODIFIED}" ]]; then echo "::debug::Matching modified files: ${ALL_MODIFIED}" - echo "any_modified=true" >>$GITHUB_OUTPUT + echo "any_modified=true" >>"$GITHUB_OUTPUT" else - echo "any_modified=false" >>$GITHUB_OUTPUT + echo "any_modified=false" >>"$GITHUB_OUTPUT" fi OTHER_MODIFIED="" @@ -187,19 +187,19 @@ else if [[ -n "${OTHER_MODIFIED}" && "$OTHER_MODIFIED" != "[]" ]]; then echo "::debug::Non Matching modified files: ${OTHER_MODIFIED}" - echo "only_modified=false" >>$GITHUB_OUTPUT - echo "other_modified_files=$OTHER_MODIFIED" >>$GITHUB_OUTPUT + echo "only_modified=false" >>"$GITHUB_OUTPUT" + echo "other_modified_files=$OTHER_MODIFIED" >>"$GITHUB_OUTPUT" elif [[ -n "${ALL_MODIFIED}" ]]; then - echo "only_modified=true" >>$GITHUB_OUTPUT + echo "only_modified=true" >>"$GITHUB_OUTPUT" fi ALL_OTHER_DELETED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" D | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}') if [[ -n "${DELETED}" ]]; then echo "::debug::Matching deleted files: ${DELETED}" - echo "any_deleted=true" >>$GITHUB_OUTPUT + echo "any_deleted=true" >>"$GITHUB_OUTPUT" else - echo "any_deleted=false" >>$GITHUB_OUTPUT + echo "any_deleted=false" >>"$GITHUB_OUTPUT" fi OTHER_DELETED="" @@ -220,10 +220,10 @@ else if [[ -n "${OTHER_DELETED}" && "${OTHER_DELETED}" != "[]" ]]; then echo "::debug::Non Matching deleted files: ${OTHER_DELETED}" - echo "only_deleted=false" >>$GITHUB_OUTPUT - echo "other_deleted_files=$OTHER_DELETED" >>$GITHUB_OUTPUT + echo "only_deleted=false" >>"$GITHUB_OUTPUT" + echo "other_deleted_files=$OTHER_DELETED" >>"$GITHUB_OUTPUT" elif [[ -n "${DELETED}" ]]; then - echo "only_deleted=true" >>$GITHUB_OUTPUT + echo "only_deleted=true" >>"$GITHUB_OUTPUT" fi if [[ "$INPUT_JSON" == "false" ]]; then ADDED=$(echo "${ADDED}" | awk '{gsub(/\|/,"\n"); print $0;}' | awk -v d="$INPUT_SEPARATOR" '{s=(NR==1?s:s d)$0}END{print s}') @@ -267,19 +267,19 @@ if [[ $INPUT_INCLUDE_ALL_OLD_NEW_RENAMED_FILES == "true" ]]; then echo "::debug::All old & new renamed files: $ALL_OLD_NEW_RENAMED" fi -echo "added_files=$ADDED" >>$GITHUB_OUTPUT -echo "copied_files=$COPIED" >>$GITHUB_OUTPUT -echo "deleted_files=$DELETED" >>$GITHUB_OUTPUT -echo "modified_files=$MODIFIED" >>$GITHUB_OUTPUT -echo "renamed_files=$RENAMED" >>$GITHUB_OUTPUT -echo "type_changed_files=$TYPE_CHANGED" >>$GITHUB_OUTPUT -echo "unmerged_files=$UNMERGED" >>$GITHUB_OUTPUT -echo "unknown_files=$UNKNOWN" >>$GITHUB_OUTPUT -echo "all_changed_and_modified_files=$ALL_CHANGED_AND_MODIFIED" >>$GITHUB_OUTPUT -echo "all_changed_files=$ALL_CHANGED" >>$GITHUB_OUTPUT -echo "all_modified_files=$ALL_MODIFIED" >>$GITHUB_OUTPUT +echo "added_files=$ADDED" >>"$GITHUB_OUTPUT" +echo "copied_files=$COPIED" >>"$GITHUB_OUTPUT" +echo "deleted_files=$DELETED" >>"$GITHUB_OUTPUT" +echo "modified_files=$MODIFIED" >>"$GITHUB_OUTPUT" +echo "renamed_files=$RENAMED" >>"$GITHUB_OUTPUT" +echo "type_changed_files=$TYPE_CHANGED" >>"$GITHUB_OUTPUT" +echo "unmerged_files=$UNMERGED" >>"$GITHUB_OUTPUT" +echo "unknown_files=$UNKNOWN" >>"$GITHUB_OUTPUT" +echo "all_changed_and_modified_files=$ALL_CHANGED_AND_MODIFIED" >>"$GITHUB_OUTPUT" +echo "all_changed_files=$ALL_CHANGED" >>"$GITHUB_OUTPUT" +echo "all_modified_files=$ALL_MODIFIED" >>"$GITHUB_OUTPUT" if [[ $INPUT_INCLUDE_ALL_OLD_NEW_RENAMED_FILES == "true" ]]; then - echo "all_old_new_renamed_files=$ALL_OLD_NEW_RENAMED" >>$GITHUB_OUTPUT + echo "all_old_new_renamed_files=$ALL_OLD_NEW_RENAMED" >>"$GITHUB_OUTPUT" fi echo "::endgroup::" diff --git a/get-sha.sh b/get-sha.sh index ccb01e75..aff577b4 100644 --- a/get-sha.sh +++ b/get-sha.sh @@ -18,7 +18,7 @@ if [[ -n "$INPUT_UNTIL" ]]; then if [[ -z "$SHA" ]]; then echo "::warning::The SHA for date '$INPUT_UNTIL' couldn't be determined, falling back to the current sha." fi - echo "sha=$SHA" >>$GITHUB_OUTPUT + echo "sha=$SHA" >>"$GITHUB_OUTPUT" else - echo "sha=$INPUT_SHA" >>$GITHUB_OUTPUT + echo "sha=$INPUT_SHA" >>"$GITHUB_OUTPUT" fi