From af7d15cc1a1e1dfc13ba11de9cadcbb14a0922a1 Mon Sep 17 00:00:00 2001 From: Evgenii Stratonikov Date: Tue, 7 Jun 2022 14:06:10 +0300 Subject: [PATCH] [#1487] innerring: Log errors in processors Log errors for network operations. The only places where we are not interested in errors are `Submit` in pool and unmarshaling. Signed-off-by: Evgenii Stratonikov --- pkg/innerring/processors/alphabet/process_emit.go | 4 ++-- pkg/innerring/processors/settlement/basic/collect.go | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/innerring/processors/alphabet/process_emit.go b/pkg/innerring/processors/alphabet/process_emit.go index 705643ba5..51ef9f584 100644 --- a/pkg/innerring/processors/alphabet/process_emit.go +++ b/pkg/innerring/processors/alphabet/process_emit.go @@ -29,7 +29,7 @@ func (ap *Processor) processEmit() { // there is no signature collecting, so we don't need extra fee err := ap.morphClient.Invoke(contract, 0, emitMethod) if err != nil { - ap.log.Warn("can't invoke alphabet emit method") + ap.log.Warn("can't invoke alphabet emit method", zap.String("error", err.Error())) return } @@ -62,7 +62,7 @@ func (ap *Processor) processEmit() { key, err := keys.NewPublicKeyFromBytes(keyBytes, elliptic.P256()) if err != nil { - ap.log.Warn("can't convert node public key to address", + ap.log.Warn("can't parse node public key", zap.String("error", err.Error())) continue diff --git a/pkg/innerring/processors/settlement/basic/collect.go b/pkg/innerring/processors/settlement/basic/collect.go index 748ab8c87..b825f9a88 100644 --- a/pkg/innerring/processors/settlement/basic/collect.go +++ b/pkg/innerring/processors/settlement/basic/collect.go @@ -29,7 +29,8 @@ func (inc *IncomeSettlementContext) Collect() { cnrEstimations, err := inc.estimations.Estimations(inc.epoch) if err != nil { inc.log.Error("can't fetch container size estimations", - zap.Uint64("epoch", inc.epoch)) + zap.Uint64("epoch", inc.epoch), + zap.String("error", err.Error())) return } @@ -42,7 +43,7 @@ func (inc *IncomeSettlementContext) Collect() { inc.log.Warn("can't fetch container info", zap.Uint64("epoch", inc.epoch), zap.Stringer("container_id", cnrEstimations[i].ContainerID), - ) + zap.String("error", err.Error())) continue } @@ -52,7 +53,7 @@ func (inc *IncomeSettlementContext) Collect() { inc.log.Debug("can't fetch container info", zap.Uint64("epoch", inc.epoch), zap.Stringer("container_id", cnrEstimations[i].ContainerID), - ) + zap.String("error", err.Error())) continue }