From c6cf8e5c0b3906f4434818d8b70e5337b8b93feb Mon Sep 17 00:00:00 2001
From: Pavel Karpy <carpawell@nspcc.ru>
Date: Tue, 31 May 2022 23:11:52 +0300
Subject: [PATCH] [#1461] engine: Fix LOCK test

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
---
 pkg/local_object_storage/engine/lock_test.go | 56 ++++++++++++++------
 1 file changed, 41 insertions(+), 15 deletions(-)

diff --git a/pkg/local_object_storage/engine/lock_test.go b/pkg/local_object_storage/engine/lock_test.go
index 415587a56..1381a1da5 100644
--- a/pkg/local_object_storage/engine/lock_test.go
+++ b/pkg/local_object_storage/engine/lock_test.go
@@ -1,6 +1,7 @@
 package engine
 
 import (
+	"context"
 	"os"
 	"strconv"
 	"testing"
@@ -14,19 +15,27 @@ import (
 	cidtest "github.com/nspcc-dev/neofs-sdk-go/container/id/test"
 	"github.com/nspcc-dev/neofs-sdk-go/object"
 	oid "github.com/nspcc-dev/neofs-sdk-go/object/id"
+	objecttest "github.com/nspcc-dev/neofs-sdk-go/object/id/test"
 	oidtest "github.com/nspcc-dev/neofs-sdk-go/object/id/test"
 	"github.com/panjf2000/ants/v2"
 	"github.com/stretchr/testify/require"
 )
 
+type tss struct {
+	expEpoch uint64
+}
+
+func (t tss) IsTombstoneAvailable(ctx context.Context, _ oid.Address, epoch uint64) bool {
+	return t.expEpoch >= epoch
+}
+
 func TestLockUserScenario(t *testing.T) {
-	t.Skip("posted bug neofs-node#1227")
 	// Tested user actions:
 	//   1. stores some object
 	//   2. locks the object
 	//   3. tries to inhume the object with tombstone and expects failure
-	//   4. saves tombstone for LOCK-object and inhumes the LOCK-object using it
-	//   5. waits for an epoch after the tombstone expiration one
+	//   4. saves tombstone for LOCK-object and receives error
+	//   5. waits for an epoch after the lock expiration one
 	//   6. tries to inhume the object and expects success
 	chEvents := make([]chan shard.Event, 2)
 
@@ -34,6 +43,13 @@ func TestLockUserScenario(t *testing.T) {
 		chEvents[i] = make(chan shard.Event, 1)
 	}
 
+	const lockerExpiresAfter = 13
+
+	cnr := cidtest.ID()
+	tombObj := generateObjectWithCID(t, cnr)
+	tombForLockID := oidtest.ID()
+	tombObj.SetID(tombForLockID)
+
 	e := testEngineFromShardOpts(t, 2, func(i int) []shard.Option {
 		return []shard.Option{
 			shard.WithGCEventChannel(chEvents[i]),
@@ -43,6 +59,7 @@ func TestLockUserScenario(t *testing.T) {
 
 				return pool
 			}),
+			shard.WithTombstoneSource(tss{lockerExpiresAfter}),
 		}
 	})
 
@@ -51,12 +68,8 @@ func TestLockUserScenario(t *testing.T) {
 		_ = os.RemoveAll(t.Name())
 	})
 
-	const lockerTombExpiresAfter = 13
-
 	lockerID := oidtest.ID()
-	tombForLockID := oidtest.ID()
 	tombID := oidtest.ID()
-	cnr := cidtest.ID()
 	var err error
 
 	var objAddr oid.Address
@@ -70,6 +83,14 @@ func TestLockUserScenario(t *testing.T) {
 	lockerAddr.SetContainer(cnr)
 	lockerAddr.SetObject(lockerID)
 
+	var a object.Attribute
+	a.SetKey(objectV2.SysAttributeExpEpoch)
+	a.SetValue(strconv.Itoa(lockerExpiresAfter))
+
+	lockerObj := generateObjectWithCID(t, cnr)
+	lockerObj.SetID(lockerID)
+	lockerObj.SetAttributes(a)
+
 	var tombForLockAddr oid.Address
 	tombForLockAddr.SetContainer(cnr)
 	tombForLockAddr.SetObject(tombForLockID)
@@ -84,6 +105,13 @@ func TestLockUserScenario(t *testing.T) {
 	require.NoError(t, err)
 
 	// 2.
+	var locker object.Lock
+	locker.WriteMembers([]oid.ID{id})
+	object.WriteLock(lockerObj, locker)
+
+	err = Put(e, lockerObj)
+	require.NoError(t, err)
+
 	err = e.Lock(cnr, lockerID, []oid.ID{id})
 	require.NoError(t, err)
 
@@ -95,11 +123,6 @@ func TestLockUserScenario(t *testing.T) {
 	require.ErrorAs(t, err, new(apistatus.ObjectLocked))
 
 	// 4.
-	var a object.Attribute
-	a.SetKey(objectV2.SysAttributeExpEpoch)
-	a.SetValue(strconv.Itoa(lockerTombExpiresAfter))
-
-	tombObj := generateObjectWithCID(t, cnr)
 	tombObj.SetType(object.TypeTombstone)
 	tombObj.SetID(tombForLockID)
 	tombObj.SetAttributes(a)
@@ -108,18 +131,20 @@ func TestLockUserScenario(t *testing.T) {
 	require.NoError(t, err)
 
 	inhumePrm.WithTarget(tombForLockAddr, lockerAddr)
+
 	_, err = e.Inhume(inhumePrm)
 	require.NoError(t, err, new(apistatus.ObjectLocked))
 
 	// 5.
 	for i := range chEvents {
-		chEvents[i] <- shard.EventNewEpoch(lockerTombExpiresAfter + 1)
+		chEvents[i] <- shard.EventNewEpoch(lockerExpiresAfter + 1)
 	}
 
 	// delay for GC
 	time.Sleep(time.Second)
 
 	inhumePrm.WithTarget(tombAddr, objAddr)
+
 	_, err = e.Inhume(inhumePrm)
 	require.NoError(t, err)
 }
@@ -183,7 +208,7 @@ func TestLockExpiration(t *testing.T) {
 	require.NoError(t, err)
 
 	var inhumePrm InhumePrm
-	inhumePrm.WithTarget(oidtest.Address(), objectcore.AddressOf(obj))
+	inhumePrm.WithTarget(objecttest.Address(), objectcore.AddressOf(obj))
 
 	_, err = e.Inhume(inhumePrm)
 	require.ErrorAs(t, err, new(apistatus.ObjectLocked))
@@ -198,7 +223,8 @@ func TestLockExpiration(t *testing.T) {
 	time.Sleep(time.Second)
 
 	// 4.
-	inhumePrm.WithTarget(oidtest.Address(), objectcore.AddressOf(obj))
+	inhumePrm.WithTarget(objecttest.Address(), objectcore.AddressOf(obj))
+
 	_, err = e.Inhume(inhumePrm)
 	require.NoError(t, err)
 }