forked from TrueCloudLab/frostfs-node
e26dc0a6e3
In previous implementation `Config.Sub` method could lead to the violation of the internal `path` slice because of `append`. This has been observed on deeply nested subsections. Fix `Config.Sub` to copy internal slice in order to prevent violations. Cover problem case in test config files and unit test. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
62 lines
1.3 KiB
Go
62 lines
1.3 KiB
Go
package config_test
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/nspcc-dev/neofs-node/cmd/neofs-node/config"
|
|
"github.com/nspcc-dev/neofs-node/cmd/neofs-node/config/internal"
|
|
configtest "github.com/nspcc-dev/neofs-node/cmd/neofs-node/config/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestConfigCommon(t *testing.T) {
|
|
configtest.ForEachFileType("test/config", func(c *config.Config) {
|
|
val := c.Value("value")
|
|
require.NotNil(t, val)
|
|
|
|
val = c.Value("non-existent value")
|
|
require.Nil(t, val)
|
|
|
|
sub := c.Sub("section")
|
|
require.NotNil(t, sub)
|
|
|
|
const nonExistentSub = "non-existent sub-section"
|
|
|
|
val = c.Sub(nonExistentSub).Value("value")
|
|
require.Nil(t, val)
|
|
})
|
|
}
|
|
|
|
func TestConfigEnv(t *testing.T) {
|
|
const (
|
|
name = "name"
|
|
section = "section"
|
|
value = "some value"
|
|
)
|
|
|
|
err := os.Setenv(internal.Env(section, name), value)
|
|
require.NoError(t, err)
|
|
|
|
c := configtest.EmptyConfig()
|
|
|
|
require.Equal(t, value, c.Sub(section).Value(name))
|
|
}
|
|
|
|
func TestConfig_SubValue(t *testing.T) {
|
|
configtest.ForEachFileType("test/config", func(c *config.Config) {
|
|
c = c.
|
|
Sub("section").
|
|
Sub("sub").
|
|
Sub("sub")
|
|
|
|
// get subsection 1
|
|
sub := c.Sub("sub1")
|
|
|
|
// get subsection 2
|
|
c.Sub("sub2")
|
|
|
|
// sub should not be corrupted
|
|
require.Equal(t, "val1", sub.Value("key"))
|
|
})
|
|
}
|