Apologies, didn't realized that the logic for node selection lived in this repo and not in frostfs-node. I added the implementation of UNIQUE
to this PR now. The change is purely additive, the…
Last time we touched it it was losing data on hard resets.
Would be good to clarify how exactly it was losing data. I suppose you mean that when the process was stopped, some writes were lost…
@anikeev-yadro @realloc is the policy-playground
command in TrueCloudLab/frostfs-node#416 sufficient for closing this? or do we want some additional tooling?
I mean just to remove the auto-generated files from PR diffs somehow, independently of what they contain. I don't know if it's possible.
Sorry, what I meant was that if the increment is always one, we can simply remove the delta everywhere and use the Inc
method, e.g.:
func (m engineMetrics) IncErrorCounter(shardID…
Can we update the PR/commit description? It refers to #26, which is misleading since I guess it's not that issue (in this repo) and it says it adds keyword UNIQUE
(which it doesn't).